Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHubActions: default extra_versions is an invalid version string? #183

Closed
mbauman opened this issue Jun 3, 2020 · 2 comments · Fixed by #185
Closed

GitHubActions: default extra_versions is an invalid version string? #183

mbauman opened this issue Jun 3, 2020 · 2 comments · Fixed by #185

Comments

@mbauman
Copy link
Member

mbauman commented Jun 3, 2020

I wasn't able to customize the versions in the way I wanted:

GitHubActions keywords to customize:
[press: d=done, a=all, n=none]
 > [ ] coverage
   [ ] destination
   [X] extra_versions
   [ ] file
   [ ] linux
   [ ] osx
   [ ] windows
   [ ] x64
   [ ] x86
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]): ["1.0", "1.4", "~1.5-0", "nightly"]
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: "1.0"
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]): "1.0", "1.4", "~1.5-0", "nightly"
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: "1.0"
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]):

(I gave up at this point and did it manually)

@mbauman
Copy link
Member Author

mbauman commented Jun 3, 2020

Aha, this is largely #184, but even after fixing my mistake it fails to recognize two versions I want (including the default nightly).

Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]):1.0, 1.4, ~1.5-0, nightly
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: ~1.5-0
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]): 1.0, 1.4, ^1.5-0, nightly
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: ^1.5-0
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]): 1.0, 1.4, 1.5.0-0, nightly
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: nightly
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143
Enter value for 'extra_versions' (Vector{VersionNumber}, comma-delimited, default=["1.0", "1.4", "nightly"]): 1.0, 1.4, 1.5.0-0, "nightly"
┌ Warning: Invalid input
│   ex = ArgumentError: invalid version string: "nightly"
└ @ PkgTemplates ~/.julia/packages/PkgTemplates/jMe8Z/src/interactive.jl:143

@christopher-dG
Copy link
Member

Ah yeah, this is certainly a bug but should be easy to fix. I definitely didn't consider setup-julia's version ranges. I'm thinking that user strings should just be accepted here as-is, since currently even doing something like 1.4.1 will give you 1.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants