Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Alternate disable_defaults syntax: plugins=[!TypeName] #162

Closed
christopher-dG opened this issue Apr 24, 2020 · 0 comments · Fixed by #167
Closed

[RFC] Alternate disable_defaults syntax: plugins=[!TypeName] #162

christopher-dG opened this issue Apr 24, 2020 · 0 comments · Fixed by #167

Comments

@christopher-dG
Copy link
Member

So currently there are a bunch of default plugins, such as Git, ProjectFile, etc. If you want to not use one of those plugins in your template, you do Template(; disable_defaults=[Git], plugins=[...]), which I've always thought was kind of clunky.
So... what if we overload ! for Type{<:Plugin} to allow for Template(; plugins=[PluginIWant, !DefaultIDontWant])?
I think it really has the same short-term discoverability as disable_defaults because you're going to have to look at the docstring for either one, and ! is IMO easier for users in the long term as they only have to worry about one keyword (plugins).
Maybe this is a terrible idea, so please don't hesitate to tell me so (or to tell me that you love the idea).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant