Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LICENSE files: add "and contributors" to default copyright #152

Closed
StefanKarpinski opened this issue Apr 5, 2020 · 9 comments · Fixed by #153
Closed

LICENSE files: add "and contributors" to default copyright #152

StefanKarpinski opened this issue Apr 5, 2020 · 9 comments · Fixed by #153

Comments

@StefanKarpinski
Copy link
Contributor

It's a best practice to include "and contributors" to the copyright statement in a LICENSE file since the copyright of a project does not solely belong to the original author unless the project has a copyright assignment agreement (which is not legal in some countries). I have been manually adding "and contributors" to the copyright line of the LICENSE file whenever I use PkgTemplates to generate a package, but it would arguably be better if that was the default.

@StefanKarpinski
Copy link
Contributor Author

StefanKarpinski commented Apr 5, 2020

Example: JuliaIO/Tar.jl@5c40343

@DilumAluthge
Copy link
Member

I 100% agree.

We should make sure to add this to all of the licenses. Of course, most people will use either MIT or ISC, but I think it will be good for us to just add this to all of the licenses.

@DilumAluthge
Copy link
Member

DilumAluthge commented Apr 6, 2020

In addition to adding this to PkgTemplates.jl, we should also add this to other packages that people use to generate new Julia packages.

For example, I think that there is a PkgSkeleton.jl package, or something like that?

Also, we should add this change to the Pkg Butler stuff from @davidanthoff

@DilumAluthge
Copy link
Member

One last thought: currently, none of my personal Julia packages or organization Julia packages have the "and contributors" language.

It would be really cool to have an automated tool that can go through all of my packages (both in my personal account and also in organizations that I own) and make PRs to add this language to the license files.

@StefanKarpinski
Copy link
Contributor Author

Here's the thing though: it should probably be the person who is attributed in the copyright line themselves who do this. But I guess as long as they do the merging that's good enough.

@DilumAluthge
Copy link
Member

Here's the thing though: it should probably be the person who is attributed in the copyright line themselves who do this. But I guess as long as they do the merging that's good enough.

Yeah, we would only open pull requests. It would be up to the author to merge those pull requests.

@christopher-dG
Copy link
Member

I'm cool with adding this to PkgTemplates but I don't really feel like doing another round of automated PRs myself this time around 😅.

@StefanKarpinski
Copy link
Contributor Author

I think gating this change on making a bunch of PRs is counterproductive. Let's fix the default now. If someone wants to make PRs, they can do so at any point.

@DilumAluthge
Copy link
Member

I think gating this change on making a bunch of PRs is counterproductive. Let's fix the default now. If someone wants to make PRs, they can do so at any point.

Agree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants