Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update workflows for githubactions + documenter + tagbot #130

Closed
ericphanson opened this issue Jan 21, 2020 · 2 comments · Fixed by #138
Closed

Update workflows for githubactions + documenter + tagbot #130

ericphanson opened this issue Jan 21, 2020 · 2 comments · Fixed by #138

Comments

@ericphanson
Copy link
Contributor

One needs a few extra steps to have GithubActions CI build docs hosted on GitHub, and to also have TagBot trigger stable docs builds:

It would be great if PkgTemplates could incorporate these modifications so that github actions + documenter + tagbot all works together without needing extra steps. (Of course, the user will still have to add the key as a secret by hand, like in the case for travis).

@christopher-dG
Copy link
Member

Thanks for reporting, I'll add the new plugin options to the plugin soon.

For the third one, I still think this should go into Documenter but I can look into adding it as a separate step here too. I've noticed that it doesn't happen if you run a shell script rather than a Docker container, so presumably the shell environment has its hosts sorted out for GitHub already.

@ericphanson
Copy link
Contributor Author

Thanks! (And thanks for all your help over on the tagbot issue). I'll ask on the Documenter issue JuliaDocs/Documenter.jl#625 about whether it should be handled in Documenter proper, or in the github actions CI file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants