-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Report URL should be unique #83
Labels
Comments
Alternatively we could have that URL include the commit hash |
This probably causes an issue reported by @vtjnash:
@maleadt I needed to fix this manually
Originally posted by @vtjnash in JuliaLang/julia#48257 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
After removing the report repo's HEAD SHA to the report URL, so that we can rewrite its history, we did cause multiple reports of the same PR to overwrite one another: JuliaLang/julia#37214 (comment)
We should probably include some random bit, or increment a counter to make the key unique.
The text was updated successfully, but these errors were encountered: