Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explicit imports #60

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

icweaver
Copy link
Member

Closes #55

Took a pass at this. Can also apply this treatment to the tests if that is preferred

Copy link

codecov bot commented Feb 21, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.62%. Comparing base (23dad1d) to head (0d97944).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #60   +/-   ##
=======================================
  Coverage   99.62%   99.62%           
=======================================
  Files          10       10           
  Lines         267      267           
=======================================
  Hits          266      266           
  Misses          1        1           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -1,6 +1,3 @@
using BSplineKit: interpolate, BSplineOrder, Natural
using DelimitedFiles
Copy link
Member Author

@icweaver icweaver Feb 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think https://github.com/JuliaAstro/DustExtinction.jl/pull/54/files#diff-9880a77dc8047f68a334d57b03fdc90fa3d1fcc9898d313378cc414f32f077eeL265 makes this stale now, so I removed the using DelimitedFiles. Not sure yet why Aqua is complaining about this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Explicit imports
1 participant