Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bump UnitfulAstro to 1.0 #32

Closed
xzackli opened this issue Feb 19, 2020 · 3 comments
Closed

bump UnitfulAstro to 1.0 #32

xzackli opened this issue Feb 19, 2020 · 3 comments

Comments

@xzackli
Copy link
Contributor

xzackli commented Feb 19, 2020

Cosmology 1.0.x should have [compat] allowing UnitfulAstro 1.0, right? The semver 1.0 would imply that things could break -- is that why it hasn't yet been done?
@giordano
Copy link
Member

is that why it hasn't yet been done?

No, it's just that no one did it. Pull requests are welcome, maybe a pr to install compat helper here would be the best option, see JuliaAstro/LombScargle.jl#14

@xzackli
Copy link
Contributor Author

xzackli commented Feb 19, 2020

Wow, I didn't know you could install Actions via PR! I'll open one.

@xzackli xzackli mentioned this issue Feb 19, 2020
Merged
@giordano
Copy link
Member

giordano commented Feb 21, 2020 •
edited
Loading

Fixed by #34

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@giordano @xzackli