Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand documentation, add discussion on counterintuitive behavior #188

Merged
merged 12 commits into from
Aug 27, 2021

Conversation

jlchan
Copy link
Contributor

@jlchan jlchan commented Apr 24, 2021

@jlchan
Copy link
Contributor Author

jlchan commented Apr 24, 2021

Ah, this probably shouldn't be merged until after #186 because the examples include StaticArrays.

@jlchan
Copy link
Contributor Author

jlchan commented Apr 24, 2021

Other possible things that might be useful to document? I don't know if it'd be necessary to add docs for

@jlchan jlchan marked this pull request as ready for review April 24, 2021 16:48
jlchan added 2 commits April 24, 2021 11:59
moving index.md to reference.md, moving overview.md to index.md (and deleting overview.md)
@ranocha
Copy link
Contributor

ranocha commented Aug 25, 2021

This seems to be a nice addition from my point of view

@piever
Copy link
Collaborator

piever commented Aug 26, 2021

Thanks again for the PR and sorry I haven't come back to it in a while, this is a massive improvement to the current docs!

I've left a few minor comments, but it's mostly very good.

About the commented things in the make.jl file, could you remove them and open a "documentation TODOs" meta issue instead? These PR is quite big already, so I thought those could be handled in a future separate PR.

@jlchan jlchan mentioned this pull request Aug 26, 2021
@jlchan
Copy link
Contributor Author

jlchan commented Aug 26, 2021

Thanks again for the PR and sorry I haven't come back to it in a while, this is a massive improvement to the current docs!

No worries at all, glad you found it useful :)

About the commented things in the make.jl file, could you remove them and open a "documentation TODOs" meta issue instead? These PR is quite big already, so I thought those could be handled in a future separate PR.

Done in #201

@jlchan jlchan requested a review from piever August 27, 2021 13:22
@piever piever merged commit 0a0032c into JuliaArrays:master Aug 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants