Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specialize diag for infinite Diagonal #152

Merged
merged 1 commit into from
Dec 12, 2023
Merged

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Dec 12, 2023

Address the specific example from #147

After this,

julia> D = Diagonal(1:∞);

julia> diag(D)
1:∞

julia> diag(D,1)
ℵ₀-element Zeros{Int64, 1, Tuple{InfiniteArrays.OneToInf{Int64}}} with indices OneToInf()

Copy link

codecov bot commented Dec 12, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9360eb6) 85.92% compared to head (40470cc) 86.02%.
Report is 4 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #152      +/-   ##
==========================================
+ Coverage   85.92%   86.02%   +0.09%     
==========================================
  Files           6        6              
  Lines         732      737       +5     
==========================================
+ Hits          629      634       +5     
  Misses        103      103              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@dlfivefifty
Copy link
Member

cool that it's type stable for constants!

@dlfivefifty dlfivefifty merged commit a1580ce into JuliaArrays:master Dec 12, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants