Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster sparse for AbstractFill #406

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Faster sparse for AbstractFill #406

wants to merge 3 commits into from

Conversation

jishnub
Copy link
Member

@jishnub jishnub commented Mar 9, 2025

There aren't particularly useful, but it can't hurt to have some faster methods.

julia> F = Fill(3, 4_000);

julia> @b sparse(F)
11.541 μs (19 allocs: 197.219 KiB) # master
3.501 μs (7 allocs: 62.656 KiB) # This PR

julia> F = Fill(3, 1_000, 1_000);

julia> @b SparseMatrixCSC{Int32,Int32}(F)
5.623 ms (52 allocs: 17.417 MiB) # master
546.454 μs (19 allocs: 7.653 MiB) # This PR

Copy link

codecov bot commented Mar 9, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.48%. Comparing base (877375f) to head (5ad9b74).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #406   +/-   ##
=======================================
  Coverage   99.48%   99.48%           
=======================================
  Files           8        8           
  Lines        1157     1161    +4     
=======================================
+ Hits         1151     1155    +4     
  Misses          6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant