-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create a BlockArraysBase package to avoid name conflicts with BlockArrays #29
Comments
Seems legit to me |
Thanks think we decided to have this package not use the BlockArrays.jl machinery (though Blockarrays could have a Diagonal type JuliaArrays/BlockArrays.jl#89) So it depends on the details Certainly open to the Idea |
I think this could make sense, since there are packages using BlockDiagonals.jl and BlockArrays.jl I had envisioned this package as being for the case where you only want block-diagonal matrices and do not want to depend on BlockArrays.jl. My thought was "if you were depending on BlockArrays.jl anyway, then why not use the "Diagonal BlockArray" type provided there?", but evidently there's some reason to use both packages 😄 And anyway a standard interface to enable switching between "block array" packages would be nice. What does @dlfivefifty think of putting generic core API of BlockArrays.jl into a "BlockArraysBase.jl" package? I guess this would include |
As it happens I'm completely redesigning BlockArrays.jl: The idea is to include all block information in the axes, so This makes a BlockArraysBase.jl package a bit simpler. It would contain:
I'm not sure about |
Great timinng! Let's come back to this once that PR is in? |
It would be fantastic if you have time to do a code review of that PR. The tests pass already, I'm just getting the doc tests to pass and in theory it would be ready to merge. |
Sorry for my ignorance, but what exactly is the difference between the "DiagonalBlockArray" and EDIT: I must have missed that there are currently no linalg-methods in |
See the discussion in JuliaStats/MixedModels.jl#216
Would you be open to having
BlockDiagonals.jl
depend on aBlockArraysBase.jl
package in which the conflicting generics likenblocks
were defined?The text was updated successfully, but these errors were encountered: