Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test examples of non-square block diagonals #97

Open
mzgubic opened this issue May 16, 2022 · 1 comment · May be fixed by #115
Open

Test examples of non-square block diagonals #97

mzgubic opened this issue May 16, 2022 · 1 comment · May be fixed by #115
Labels
good first issue Good for newcomers

Comments

@mzgubic
Copy link
Collaborator

mzgubic commented May 16, 2022

This package went from supporting only square blocks to supporting non-square blocks as well. It would be good for tests to have more coverage of this use case to identify/avoid bugs such as #96
@mzgubic mzgubic added the good first issue Good for newcomers label May 16, 2022
@mzgubic mzgubic mentioned this issue May 16, 2022
Closed
@Horneffer Horneffer linked a pull request Sep 1, 2022 that will close this issue
Open
@mzgubic
Copy link
Collaborator Author

mzgubic commented Sep 6, 2022

Hi @Horneffer, thanks for opening a PR.

I think we might want to be a little more systematic about this. Instead of adding a new file with tests for nonsquare matrices we should probably change the current tests such that they run for both the square and non-square matrices. This should be done in a way such that we add new tests they would automatically test the nonsquare blocks as well.

One way to do this would be to define b1, b2, b3 twice (square and non-square) and the rest of the helpers inside runtests.jl, loop over them, and include the test files for each version. See AxisKeys.jl for an example. (AxisKeys only defines a single variable outside).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

I wrote tests for non-square blocks Horneffer/BlockDiagonals.jl
1 participant
@mzgubic