-
-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
JLayers docstring needs update #382
Comments
Just want to also point out that for the example in the docstring, the Maybe consider replacing |
Yes good point. I think we might want to use |
@Wikunia I am not sure if I can agree on that one. This would present shorthands as mainstream Javis way of defining objects which is not good as shorthands are just an easy way of representing anonymous functions. It's like giving a mathematical formula without deriving it. 😅 |
I think it makes sense to start with the anonymous functions in the tutorials as we do. However for docstrings it should be preferably be all possible without defining specific functions in each of them. Another option would be to use |
Currently the docstring of
JLayer
see: https://wikunia.github.io/Javis.jl/stable/references/#Javis.@JLayer-Tuple{Expr,Int64,Int64,Any,QuoteNode,Expr}misses the
transparent
inside the function arguments and I think we should write:transparent
and:opaque
as codeThe docstring of
to_layer_m
should also me updated and maybe we should call it_to_layer
as it is an internal method that is normally not called by the user?Maybe you @Sov-trotter can fix this 😉
The text was updated successfully, but these errors were encountered: