Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension to RFrames #331

Closed
codejaeger opened this issue Apr 27, 2021 · 3 comments · Fixed by #338
Closed

Extension to RFrames #331

codejaeger opened this issue Apr 27, 2021 · 3 comments · Fixed by #338
Labels
enhancement New feature or request

Comments

@codejaeger
Copy link
Contributor

codejaeger commented Apr 27, 2021

Is your feature request related to a problem? Please explain.
When specifying a relative frame range it would be would be nice to have an option to specify if the reference frame was the previous object's first or last frame. A particular use case is when objects need to be added to the canvas one after another based on their starting frame.

Describe the solution you'd like
Add the argument from_start::Bool to RFrames to indicate the frame range for this object.
Example:

ball = Object(Rframes(5:10, true), (args...)->somefunc())

Describe alternatives you've considered
A workaround is to create a function to access the starting frame of the desired object in a way like start(obj). The only problem seems to be when the previous object (or a reference to it) is not known.

Additional context
Both the methods were suggested by @Wikunia on Javis' zulip thread.

@codejaeger codejaeger added the enhancement New feature or request label Apr 27, 2021
@Wikunia
Copy link
Member

Wikunia commented Apr 27, 2021

Thanks for opening the issue. Yeah the function might need some extra work. Interested in ideas by @Sov-trotter

@Sov-trotter
Copy link
Member

Thanks for the ping @Wikunia . I'll get back here in a few days as I am currently out of town. 😀

@TheCedarPrince
Copy link
Member

I think we can close this issue based on the above Zulip discussion. :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
4 participants