Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In depth review of MLJModel loading time is necessary #118

Closed
tlienart opened this issue Nov 1, 2019 · 1 comment
Closed

In depth review of MLJModel loading time is necessary #118

tlienart opened this issue Nov 1, 2019 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed perf

Comments

@tlienart
Copy link
Collaborator

tlienart commented Nov 1, 2019

Importing MLJModels takes way longer than it should given that it doesn't really include any packages beyond the basic ones.

In view of the recent speedup achieved by tweaking how the metadata was retrieved, it would be useful to know what takes time when loading MLJModels and dig.

I suspect some of the work to reduce this latency will go in fixing things in MLJBase as well.

Help to do this would be very welcome (at this point it's just a case of figuring out what operation takes how much time when loading everything).

-- the first thing to check is that the actions where MLJModels retrieves the list of models and metadata is not super slow.

@tlienart tlienart added enhancement New feature or request help wanted Extra attention is needed perf labels Nov 1, 2019
@tlienart
Copy link
Collaborator Author

Hehe, now it's ~4s 😄 most of which is MLJBase I think.

We can probably further improve this but for now I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed perf
Projects
None yet
Development

No branches or pull requests

1 participant