Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor release with Gramian training for OLS #151

Merged
merged 7 commits into from
Oct 2, 2023
Merged

Minor release with Gramian training for OLS #151

merged 7 commits into from
Oct 2, 2023

Conversation

tlienart
Copy link
Collaborator

@tlienart tlienart commented Oct 2, 2023

Minor release with #146

ablaom and others added 7 commits February 14, 2023 20:48
* proof of concept

* AbstractMatrix -> AVR

* cleaner impl

* endline

* fix error type

* construct kernels if not passed in

* add test case for implicit gram construction

* last endline

* check for isempty instead of iszero
@codecov
Copy link

codecov bot commented Oct 2, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (a872d7c) 96.11% compared to head (88b5c5f) 96.13%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   96.11%   96.13%   +0.01%     
==========================================
  Files          22       22              
  Lines         876      905      +29     
==========================================
+ Hits          842      870      +28     
- Misses         34       35       +1     
Files Coverage Δ
src/fit/default.jl 88.46% <100.00%> (+2.74%) ⬆️
src/fit/proxgrad.jl 95.74% <100.00%> (+0.39%) ⬆️
src/fit/solvers.jl 100.00% <ø> (ø)
src/glr/d_l2loss.jl 100.00% <100.00%> (ø)
src/glr/utils.jl 92.30% <100.00%> (+1.39%) ⬆️
src/mlj/classifiers.jl 100.00% <ø> (ø)
src/utils.jl 96.96% <91.66%> (-0.74%) ⬇️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tlienart tlienart merged commit 0887cfe into master Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants