Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

If verbosity > 0, print the name of the selected solver when fit! is called #114

Merged
merged 2 commits into from
Feb 27, 2022
Merged

If verbosity > 0, print the name of the selected solver when fit! is called #114

merged 2 commits into from
Feb 27, 2022

Conversation

DilumAluthge
Copy link
Member

No description provided.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2022

Codecov Report

Merging #114 (d835cf8) into dev (0e19298) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##              dev     #114   +/-   ##
=======================================
  Coverage   96.05%   96.06%           
=======================================
  Files          21       21           
  Lines         861      863    +2     
=======================================
+ Hits          827      829    +2     
  Misses         34       34           
Impacted Files Coverage Δ
src/mlj/interface.jl 88.70% <100.00%> (+0.37%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0e19298...d835cf8. Read the comment docs.

@DilumAluthge
Copy link
Member Author

@tlienart @ablaom This is now ready for review.

Copy link
Member

@ablaom ablaom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds reasonable to me. By default (verbosity=1) MLJ tends to be somewhat verbose, so this is consistent.

@ablaom ablaom merged commit fab12d2 into JuliaAI:dev Feb 27, 2022
@ablaom ablaom mentioned this pull request Feb 27, 2022
@DilumAluthge DilumAluthge deleted the dpa/verbosity-print-solver-when-fitting branch February 28, 2022 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants