Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade it to (async) CEv1 & update the test #30

Closed
tomalec opened this issue Aug 28, 2017 · 1 comment
Closed

Upgrade it to (async) CEv1 & update the test #30

tomalec opened this issue Aug 28, 2017 · 1 comment
Assignees
@tomalec @alshakero

Comments

@tomalec
Copy link
Member

tomalec commented Aug 28, 2017

We decided to go with document-register-element polyfill of CEv1 with is attribute as webcomponents/custom-elements#88 is stale. Then, unfortunately, it makes CEReactions asynchronous, so we will have to update the tests for it.
@warpech warpech mentioned this issue Oct 3, 2017
Closed
@warpech
Copy link
Contributor

warpech commented Nov 28, 2017

After we make i-t an autonomous custom element, there is no need for async lifecycle callbacks.

Closing as won't fix.

@warpech warpech closed this as completed Nov 28, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomalec tomalec

@alshakero alshakero

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@tomalec @warpech @alshakero