BREAKING CHANGE: Use WifiUtils to connect with a wifi network

[eliaslecomte]

Starting Android 10, it's no longer possible to connect (as an app) to wifi networks like before.

What can an app still do:

Temporary connect to a wifi access point (for example to setup an IoT device)
Suggest a network, but the OS can choose what to do with it.
With this PR, i've switched the connection logic to use WifiUtils which just released support for option 1.

Advantages of using WifiUtils:

Works well on different android versions
Only resolves when the app is connected to the network
Has a good retry mechanism built in
Well written code

[eliaslecomte]

It is true that the android 10 support from WifiUtils is still early. We have tested this on multiple android devices and when we can improve, we will contribute to WifiUtils and react-native-wifi-reborn.
But doing nothing is no option, even when you target Android 9, some android 10 devices will block wifi connection attempts with the previous code resulting in a nonfunctioning app.

[Rapsssito]

As mentioned here (#28 (comment)), right now, you can connect to open WiFi networks passing null as password. Could you confirm if this is still the case with this change?

[Rapsssito]

@JuanSeBestia, why would this be a BREAKING CHANGE?

[eliaslecomte]

@JuanSeBestia, why would this be a BREAKING CHANGE?

Because this is a hefty change regardign connecting on Android. For one, it uses new code for pre android 10 and starting 10 it's also completely different in it's way, that only the current app can use the wifi network.

[Rapsssito]

@eliaslecomte, for semantic-release compatibility, could you add to your initial post body something along the lines of:

BREAKING CHANGE: ...broken functionalities

following the AngularJS Git Commit Convention?

[Rapsssito]

@eliaslecomte, should we wait for @JuanSeBestia opinion?
LGTM. It will fix a lot of future issues and focuses our work in JavaScript and Objective-C.

[eliaslecomte]

I do think @JuanSeBestia should approve :-).

[JuanSeBestia]

1. When you do a commit changing readme like chore: update the readme you would use the prefix docs, like docs: update the readme
2. Really looks very clean code in android
3. We forgot iOS :(

We want to clarify changing the versión in the readme if someone need the previous version, wich versión would need to install

In the nutshell, I will allow marge this MR :)

[JuanSeBestia]

🎉 This PR is included in version 3.0.0 🎉

The release is available on:

• GitHub release
• npm package (@latest dist-tag)

Your semantic-release bot 📦🚀