Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Snippet in Github Actions Marketplace is wrong #8

Closed
MarekLani opened this issue Dec 9, 2021 · 1 comment
Closed

Snippet in Github Actions Marketplace is wrong #8

MarekLani opened this issue Dec 9, 2021 · 1 comment

Comments

@MarekLani
Copy link
Contributor

Bellow stated snippet on Github Actions Marketplace also Readme uses wrong values for retry-all and follow-redirects. Using proposed values yes, no results in following error:

Error: TypeError: Input does not meet YAML 1.2 "Core Schema" specification: follow-redirect
Support boolean input list: true | True | TRUE | false | False | FALSE

Solution: docs should use true | True | TRUE | false | False | FALSE

steps:
  - name: Check the deployed service URL
    uses: jtalk/url-health-check-action@v2
    with:
      # Check the following URLs one by one sequentially
      url: https://example.com|http://example.com
      # Follow redirects, or just report success on 3xx status codes
      follow-redirect: no # Optional, defaults to "no"
      # Fail this action after this many failed attempts
      max-attempts: 3 # Optional, defaults to 1
      # Delay between retries
      retry-delay: 5s # Optional, only applicable to max-attempts > 1
      # Retry all errors, including 404. This option might trigger curl upgrade.
      retry-all: no # Optional, defaults to "no"
@Jtalk
Copy link
Owner

Jtalk commented Dec 11, 2021

Hey @MarekLani, sorry about that. The yaml spec update probably came with some of the GH dependencies, and I forgot to update the readme. Thanks for the PR!

@Jtalk Jtalk closed this as completed Dec 11, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants