-
Notifications
You must be signed in to change notification settings - Fork 186
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use HashWithIndifferentAccess, instead of symbolize_keys #386
Conversation
@chingor13, @gaorlov could you please review? |
This looks great! Can you please update the changelog md? |
Thanks @tilo this will be a big help for us. |
@gaorlov CHANGELOG is updated |
i meant to mention this earlier: what's the thinking behind adding pry to the gemspec? The approach so far has been to try to keep the gemspec footprint to a minimum unless absolutely necessary. Do you feel that it's necessary? |
@gaorlov
|
@gaorlov do you think it's good to go, or do you want me to remove |
The approach so far has been to keep the dependency footprint - both dev and release - to the minimum necessary to run and test. However, if you feel strongly that the addition of pry will benefit the gem I don't have any strong opposition to it. |
I removed |
|
use HashWithIndifferentAccess, instead of symbolize_keys