Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deletion for primary keys #330

Merged
merged 2 commits into from
Jan 24, 2019
Merged

Conversation

gaorlov
Copy link
Collaborator

@gaorlov gaorlov commented Jan 23, 2019

Adding deletion support for resources whose primary_key is not id.
Now if you have a resource that looks like

module MyAPI
  class User < Base
    self.primary_key = :guid
  end
end

the DELETE request will use the guid from attributes rather than doing a DELETE my.api/users/

@gaorlov gaorlov requested a review from senid231 January 23, 2019 15:47
Copy link
Member

@senid231 senid231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@senid231 senid231 merged commit 5cfdf92 into JsonApiClient:master Jan 24, 2019
senid231 added a commit to senid231/json_api_client that referenced this pull request Jan 24, 2019
@senid231
Copy link
Member

@gaorlov I think we can release gem now

@gaorlov
Copy link
Collaborator Author

gaorlov commented Jan 24, 2019

Marvelous. I'll release it in a couple hours. Do you think 1.8.1 or 1.9.0?

@senid231
Copy link
Member

@gaorlov I think it should be 1.9.0 because we added new features

@gaorlov
Copy link
Collaborator Author

gaorlov commented Jan 25, 2019

okay. 1.9.0 is live

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants