Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implemented translation feature #35

Open
wants to merge 36 commits into
base: master
Choose a base branch
from

Conversation

Shinigami92
Copy link
Contributor

next steps:

  • german locales
  • improve selection of language

english HALLOWEEN_2016 complete
german as second language -> test with Hexe
Added language selection-box to settings (needs improvement :( )
The side doesn't reload anymore after you selected a language :)
@Shinigami92
Copy link
Contributor Author

improved language selection -> DONE

@Shinigami92
Copy link
Contributor Author

german translation for current event added

@Js41637
Copy link
Owner

Js41637 commented Jan 28, 2017

Hey thanks for this, I won't be able to merge now as we're in the process of a lot of core changes to the layout and backend. I will merge it into a branch later and make a few changes for how I would like it.

@Shinigami92
Copy link
Contributor Author

Ok so now I go playing a bit overwatch
But can you tell me, whether you can extract the language names from an API? So I don't have to write everything manualy?
Otherwise this is lot of work... but makeable

@Js41637
Copy link
Owner

Js41637 commented Jan 28, 2017

I'm sure you can just run it all through google translate, I won't be manually translating anything, you don't have to translate it all if you don't want too, i'm sure if someone wants it enough they can do it.

@Shinigami92
Copy link
Contributor Author

OK, then I will translate everything manually to german with my game
if someone want france or anything else, s/he can do it :)

@Shinigami92
Copy link
Contributor Author

Link to issue: issue#24

@nduriez
Copy link

nduriez commented Feb 1, 2017

I've started to implement French translation locally.

@nduriez
Copy link

nduriez commented Feb 1, 2017

I finished the French localization but i can't push my changes because this push request hasn't been merged yet

@Shinigami92
Copy link
Contributor Author

@JigAma I have invited you to my fork.
Now you can make a new branch on my fork, commit your french localization to it and the make a merge request to my master-branch in my fork
I will review the changes you made and the it will be added in this pull request

nduriez and others added 3 commits February 1, 2017 19:29
Added "fr_FR" to $rootScope.languages in js\main.js
Created the file "fr_FR.json" in \locales
@Shinigami92
Copy link
Contributor Author

Review french translation done

@Shinigami92
Copy link
Contributor Author

I will soon look at all the changes and then continue with the translation.
But maybe first I will wait a bit until the master isn't rapidly updated anymore :)

@Shinigami92
Copy link
Contributor Author

translation from language-keys to english is working
de and fr are only working for events, because the old translations were compatible. only some aren't and will fallback to english

so i will translate the other missing keys the next days
and hopefully JigAma will be back and translate the french

@Shinigami92
Copy link
Contributor Author

Shinigami92 commented Apr 26, 2017

Sorry that I'm working a bit slow
Have currently some exams

@nduriez
Copy link

nduriez commented May 19, 2017

I'm waiting Js to merge the branch as it is right now before making the new translation because we hadn't have news since a bit of time now and I don't want to do it if i'm not sure it will be used

@Shinigami92
Copy link
Contributor Author

Yes me too
I havn't any response from JS whether he want to merge this branch
Currently i have translated all event items but not the regular class items (they will fallback to english)
It is a huge amount of work to translate the items and there are dublicates in event and regular with the current datastructur

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants