fix: fixes reading tsconfig and handling compilerOptions

[rubiesonthesky]

PR Checklist

• Addresses an existing open issue: fixes 🐛 Bug: suppressTypeErrors: program's compilerOptions are malformed #1532
• That issue was marked as status: accepting prs
• Steps in CONTRIBUTING.md were taken

Overview

• Fixes reading tsconfig and handling the values.
  • This can be seen in the snapshot files, where values for compilerOptions have been changed.
• Options from typestat.json should not disable noImplicitAny or noImplicitThis if they are enabled in tsconfig.

[rubiesonthesky]

I guess I should update this PR now :D

[JoshuaKGoldberg]

😅 yeah that'd be great. But if you don't have the time and don't want to deal with merge conflicts from me skipping out for a half a year, no worries - lmk and I can step in! ❤️

[codecov]

Codecov Report

Attention: Patch coverage is 87.09677% with 4 lines in your changes missing coverage. Please review.

Project coverage is 74.75%. Comparing base (a505078) to head (d13b85d).
Report is 21 commits behind head on main.

Files with missing lines	Patch %	Lines
src/options/loadPendingOptions.ts	0.00%	2 Missing ⚠️
src/options/parseRawCompilerOptions.ts	81.81%	2 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #1542      +/-   ##
==========================================
- Coverage   74.81%   74.75%   -0.07%     
==========================================
  Files         171      171              
  Lines        7108     7078      -30     
  Branches     1049     1039      -10     
==========================================
- Hits         5318     5291      -27     
+ Misses       1785     1781       -4     
- Partials        5        6       +1     

Flag	Coverage Δ
mutation	69.55% <87.09%> (-0.09%)	⬇️
unit	12.57% <3.22%> (+0.03%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[rubiesonthesky]

@JoshuaKGoldberg This is now ready for review. Sorry that it took so long!

From test snapshots you can see that the compiler options looks much better now. There is no longer 2 nested compilerOptions. :) A lot type errors are also gone from integration tests, since now it's handling those options better.

[rubiesonthesky]

I need to revisit this again. I’m having hard time understanding why different change fixed another bug. But when putting together with this change with this change the bug appeared again.

[rubiesonthesky]

Not needed anymore