Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UiConfirm show Modal with cancel CSS issue #205

Closed
fuchao2012 opened this issue Feb 3, 2017 · 6 comments
Closed

UiConfirm show Modal with cancel CSS issue #205

fuchao2012 opened this issue Feb 3, 2017 · 6 comments

Comments

@fuchao2012
Copy link

When first pop up modal window, just like this

image

The cancel might have some CSS problem.

@EmilMoe
Copy link
Contributor

EmilMoe commented Feb 3, 2017

Also in the demo cases in the doc's I noticed this error.

@JosephusPaye
Copy link
Owner

JosephusPaye commented Feb 3, 2017

It's not a bug, that shows which button is focused (in this case the Cancel button).

Try tabbing and you will see the focus change.

@EmilMoe
Copy link
Contributor

EmilMoe commented Feb 3, 2017

But this is not the way Google Material sets focus and it gives the impression that it's a bug. A very eye catching one for me and seemingly more.

Google simply darkens the background a bit to show highlight https://material.angularjs.org/latest/demo/button

@JosephusPaye
Copy link
Owner

JosephusPaye commented Feb 12, 2017

While it does seem weird, this is actually in the specs. See https://material.io/guidelines/components/buttons.html#buttons-style under Behavior section.

It is also a place that Angular Material deviates from the specs, see angular/material#142.

I will look into it again to see how it can be tweaked visually to look less like the focus is "stuck".

@JosephusPaye
Copy link
Owner

keen-ui-focus-ring-animation

This was changed in 941e0a9, to be released soon. Now the focus ring animates to fill the button.

To try it:

# npm
npm install keen-ui@JosephusPaye/Keen-UI#next

# yarn
yarn add keen-ui@JosephusPaye/Keen-UI#next

See the changelog for all changes.

@JosephusPaye
Copy link
Owner

Released in v1.1.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants