-
-
Notifications
You must be signed in to change notification settings - Fork 261
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stop RCS1031, RCS1208 and RCS1211 from being applied if the local variables overlap. #1039
Merged
josefpihrt
merged 11 commits into
dotnet:main
from
jamesHargreaves12:fix/RCS1031-and-RCS1211
Mar 19, 2023
Merged
Stop RCS1031, RCS1208 and RCS1211 from being applied if the local variables overlap. #1039
josefpihrt
merged 11 commits into
dotnet:main
from
jamesHargreaves12:fix/RCS1031-and-RCS1211
Mar 19, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamesHargreaves12
changed the title
Stop RCS1031 and RCS1211 from being applied if the local variables overlap.
Stop RCS1031, RCS1208 and RCS1211 from being applied if the local variables overlap.
Feb 18, 2023
josefpihrt
requested changes
Feb 27, 2023
src/Common/CSharp/Analysis/ReduceIfNesting/ReduceIfNestingAnalysis.cs
Outdated
Show resolved
Hide resolved
src/Common/CSharp/Analysis/ReduceIfNesting/ReduceIfNestingAnalysis.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/RemoveUnnecessaryBracesInSwitchSectionAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/RemoveUnnecessaryBracesInSwitchSectionAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Common/CSharp/Analysis/ReduceIfNesting/ReduceIfNestingAnalysis.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/RemoveUnnecessaryBracesInSwitchSectionAnalyzer.cs
Outdated
Show resolved
Hide resolved
src/Analyzers/CSharp/Analysis/RemoveUnnecessaryBracesInSwitchSectionAnalyzer.cs
Outdated
Show resolved
Hide resolved
josefpihrt
reviewed
Mar 19, 2023
src/Common/CSharp/Analysis/ReduceIfNesting/ReduceIfNestingAnalysis.cs
Outdated
Show resolved
Hide resolved
josefpihrt
reviewed
Mar 19, 2023
src/Common/CSharp/Analysis/ReduceIfNesting/ReduceIfNestingAnalysis.cs
Outdated
Show resolved
Hide resolved
josefpihrt
approved these changes
Mar 19, 2023
Thanks for the PR! 👍 |
Haarmees
pushed a commit
to Haarmees/Roslynator
that referenced
this pull request
Oct 30, 2023
…iables overlap. (dotnet#1039) Co-authored-by: Josef Pihrt <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For cases, where the same local variable is declared inside the if and else blocks e.g.
The diagnostic RCS1211 Should not be raised.
Removing the else block would cause a compiler error "A local variable named 'x' cannot be declared in this scope because it would give a different meaning to 'x', which is already used in a parent or current scope to denote something else".
The same thing is true for switch case brackets (RCS1031).