Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] actually run the WASM start function #284

Open
JonasKruckenberg opened this issue Feb 11, 2025 · 0 comments
Open

[bug] actually run the WASM start function #284

JonasKruckenberg opened this issue Feb 11, 2025 · 0 comments
Labels
bug Something isn't working sys: WASM Related to the WebAssembly Engine

Comments

@JonasKruckenberg
Copy link
Owner

The WASM engine currently doesn't call the modules start function during initialization which obviously isn't correct. AFAIK the correct place to call the function is here:

k23/kernel/src/wasm/runtime/instance.rs

Line 77 in c566320


see the spec for details on start function execution.
@JonasKruckenberg JonasKruckenberg added enhancement New feature or request sys: virtmem Related to the virtual memory subsystem bug Something isn't working wasm-proposal Related to a WebAssembly proposal sys: WASM Related to the WebAssembly Engine and removed enhancement New feature or request sys: virtmem Related to the virtual memory subsystem wasm-proposal Related to a WebAssembly proposal labels Feb 11, 2025
@JonasKruckenberg JonasKruckenberg changed the title fix: actually run the WASM start function [bug] actually run the WASM start function Feb 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working sys: WASM Related to the WebAssembly Engine
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JonasKruckenberg