Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add address labelling support to RPC API #1472

Open
kristapsk opened this issue Apr 12, 2023 · 1 comment
Open

Add address labelling support to RPC API #1472

kristapsk opened this issue Apr 12, 2023 · 1 comment

Comments

@kristapsk
Copy link
Member

kristapsk commented Apr 12, 2023

I agree with the rest apart from the above two comments.

However, as with all such UI type changes, it makes sense to include an adaptation to both Qt and, especially, to the RPC interface, to allow clients to use them.

Originally posted by @AdamISZ in #1468 (comment)

There is currently none. Could be optional parameters when requesting new address and when creating transactions.

@AdamISZ
Copy link
Member

AdamISZ commented Apr 13, 2023

Agree. Also adding 'help wanted' label since this would be a good way for someone to familiarize themselves with how to update the API. Essentially, you can see in e.g. #1461 that the changes needed are in docs/api/wallet_rpc.yaml (specification - this also auto-generates docs) and jmclient/jmclient/wallet_rpc.py (add method here .. other source files may or may not need changes, of course).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants