Upgrade to latest solc 0.5.8 #616
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elenadimitrova
force-pushed
the
maintenance/upgrade-solc-0.5.8
branch
3 times, most recently
from
c7f7fa2
to
f7e531e
Compare
area
reviewed
May 20, 2019
truffle.js
Outdated
| @@ -34,7 +34,7 @@ module.exports = { | |||
| } | |||
| }, | |||
| mocha: { | |||
| reporter: "mocha-circleci-reporter", | |||
| reporter: "eth-gas-reporter", | |||
|
Not a bad idea with the |
|
No, was just wondering. It'd have pros and cons, so happy to leave as-is. |
area
approved these changes
May 20, 2019
as these have an issue with the latest solc 0.5.8 Logged dapphub/ds-note#4
…nstances of our own Token
elenadimitrova
force-pushed
the
maintenance/upgrade-solc-0.5.8
branch
from
d0fcea4
to
0fa0a71
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also due to dapphub/ds-note#4 removed
DSTokenfrom tests and instead use instances of our ownToken