-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove deprecated functions #1193
Draft
area
wants to merge
11
commits into
develop
Choose a base branch
from
maint/deprecation-removal
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
5 times, most recently
from
October 14, 2024 17:33
674adf8
to
f2a8604
Compare
area
commented
Oct 15, 2024
.storage-layouts-normalized/contracts/colony/Colony.sol:Colony.json
Outdated
Show resolved
Hide resolved
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
2 times, most recently
from
October 25, 2024 18:30
639ffe5
to
74127f8
Compare
kronosapiens
added
ready-for-review
in-progress
and removed
in-progress
ready-for-review
labels
Oct 25, 2024
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
October 31, 2024 20:40
16cb5de
to
373c610
Compare
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
2 times, most recently
from
November 22, 2024 15:49
0abe21d
to
68f68d4
Compare
Note that the commit hash for shoving the version numbers is here: |
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
November 22, 2024 15:58
68f68d4
to
f79ab36
Compare
kronosapiens
force-pushed
the
maint/deprecation-removal
branch
from
November 22, 2024 16:12
f79ab36
to
2cc3dba
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For a while, we've been marking functions as deprecated, and not doing anything further.
The crows have come home to roost.
Ready for review, I reckon, but not to merge - both because of the upcoming release, and because this will need testing against the dapp and the cdapp to make sure they're not using anything that we're removing, and then having those updated accordingly.
The functions removed are as follows:
makeArbitraryTransactions
makeSingleArbitraryTransaction
transferExpenditureViaArbitration
setExpenditureRecipient
setExpenditurePayout
setExpenditureSkill
setExpenditureClaimDelay
moveFundsBetweenPots
(old signature)In addition,
makeArbitraryTransaction
gains a new_strict
argument