Fix setExpenditurePayouts logic #1154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronosapiens
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Curiously enough, I had just caught this over here: https://github.com/JoinColony/colonyNetwork/pull/1150/files#diff-ff53e85cbf7115cdaa7bd0dba0cb20f911b4cd56e6ba1fa58d35ea6dc2655a35R323
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
setExpenditurePayoutslogic is incorrect in the core contracts. When multiple values were set with the same call, the funding potpayoutsproperty would not be updated / set correctly.The updated/added test fail without the contracts changes, demonstrating the issue.
I don't believe we need to take any actions in terms of checking for 'wrong' expenditures - they're not used in the frontend (yet - development of expenditures surfaced this issue), and the consequences are 'only' that in the case of expenditures with multiple payouts, some payouts will need a new expenditure made. Funds are incorrectly returned to the domain containing the expenditure, so they can be used to pay out again via another expenditure.