Fix MTX broadcaster intermittent bug; pay for bridge transactions #1112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/never-float-hexlify
branch
from
e67a957 to
bf2220b
Compare
packages/metatransaction-broadcaster/MetatransactionBroadcaster.js
Outdated
Show resolved
Hide resolved
area
force-pushed
the
maint/never-float-hexlify
branch
2 times, most recently
from
0652420 to
865e1b6
Compare
area
force-pushed
the
maint/never-float-hexlify
branch
from
865e1b6 to
2bcb788
Compare
kronosapiens
force-pushed
the
maint/never-float-hexlify
branch
2 times, most recently
from
9770733 to
b8a1e95
Compare
kronosapiens
previously approved these changes
Jan 26, 2023
|
@area I modified the last commit (it was a small change; I figured it would be more expedient) -- it's approved, take a look and merge if you're happy with it. |
kronosapiens
force-pushed
the
maint/never-float-hexlify
branch
from
b8a1e95 to
feb6764
Compare
kronosapiens
approved these changes
Jan 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1111 . We want people using the safe-control feature to not be obliged to pay for the bridging transaction on the Gnosis Chain side, so have whitelisted the two (currently known / cared about) bridge contracts, and allowed calls to the arbitrary transactions functions on a colony to call exactly
requireToPassMessageon those contracts and still be eligible for using our metatransaction broadcaster.Also fixes an untracked bug where, if the gas-price oracle used returned certain values, a non-integer would be passed to hexlify which would error. That should now no longer be possible, regardless of what value is returned by the oracle.
Based on #1113 so no merging until that is merged.