Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix random ordering of miners in response windows #1102

Merged
merged 12 commits into from
Dec 16, 2022
Merged

Fix random ordering of miners in response windows #1102

merged 12 commits into from
Dec 16, 2022

Commits on Dec 15, 2022

  1. Add test demonstrating issue with miner ordering

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    e3139f4 View commit details
    Browse the repository at this point in the history

  2. Update miner to explicitly call soon-to-be-deprecated function

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    3524289 View commit details
    Browse the repository at this point in the history

  3. Correctly randomise allowed order of miner responses

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    083e4ea View commit details
    Browse the repository at this point in the history

  4. If a miner loses a race, allow it to keep mining

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    6d130ec View commit details
    Browse the repository at this point in the history

  5. Changes following first review

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    cce8f9a View commit details
    Browse the repository at this point in the history

  6. Do not clobber global variable in tests

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    7627200 View commit details
    Browse the repository at this point in the history

  7. Overlooked migration from ethers v4->v5

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    2bca53d View commit details
    Browse the repository at this point in the history

  8. Missed updates to Dockerfiles

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    be1fad9 View commit details
    Browse the repository at this point in the history

  9. Changes after review

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    daaafdc View commit details
    Browse the repository at this point in the history

  10. Add comments about extra gas

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    486f0a3 View commit details
    Browse the repository at this point in the history

  11. Make function sig in test more explicit

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    fecec7e View commit details
    Browse the repository at this point in the history

  12. Second attempt at fix for issue

    @area @kronosapiens
    area authored and kronosapiens committed Dec 15, 2022
    Configuration menu
    Copy the full SHA
    8bcf179 View commit details
    Browse the repository at this point in the history