Add function to recover staked funds in misaligned motions #1082
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| /// @return The staker reward and the reputation penalty (if any) | ||
| function getStakerReward(uint256 _motionId, address _staker, uint256 _vote) external view returns (uint256, uint256); | ||
|
|
||
| function createClaimDelayAction(bytes memory action, uint256 value) |
There was a problem hiding this comment.
Is this external? I thought this was an internal function. I may have made it public for testing at one point.
There was a problem hiding this comment.
It is, and has been for a while. Not intending to do a pass of that type of thing here, but we can pick it up down the line.
contracts/extensions/VotingReputation/VotingReputationMisalignedRecovery.sol
Outdated
Show resolved
Hide resolved
contracts/extensions/VotingReputation/VotingReputationMisalignedRecovery.sol
Outdated
Show resolved
Hide resolved
contracts/extensions/VotingReputation/VotingReputationMisalignedRecovery.sol
Outdated
Show resolved
Hide resolved
contracts/extensions/VotingReputation/VotingReputationMisalignedRecovery.sol
Outdated
Show resolved
Hide resolved
area
force-pushed
the
maint/recover-misalignment-locked-funds
branch
7 times, most recently
from
f92edc5
to
889d682
Compare
area
force-pushed
the
maint/recover-misalignment-locked-funds
branch
from
889d682
to
c236334
Compare
area
force-pushed
the
maint/recover-misalignment-locked-funds
branch
from
fc94864
to
189ed1c
Compare
|
This was included in #1084, but if you want more changes will need rebasing and more work from me before being merged in to develop. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #1081, so no merging. Broadly speaking:
finalizedboolean.