Improve noProof oracle endpoint and fast-failure of proof endpoint #1073
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice one, this should clean up the browser console a little :) |
kronosapiens
previously approved these changes
Jul 25, 2022
| @@ -901,8 +902,8 @@ class ReputationMiner { | |||
|
|
|||
| // Not in the accepted or next tree, so let's look at the DB | |||
|
|
|||
| const allReputations = await this.queries.getAllReputationsInHash.all(rootHash); | |||
| if (allReputations.length === 0) { | |||
| const res = await this.queries.getReputationHashCount.get(rootHash); | |||
kronosapiens
force-pushed
the
maint/oracle-performance-2
branch
from
d9d90b3
to
53afbe4
Compare
kronosapiens
approved these changes
Jul 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When I made the
noProofendpoint, I removed the logic around building the tree, as it wasn't needed. But I could have also removed the bit where it loads all reputations in the state from the database! So I've done that. Similarly, the proof endpoint will now not load all reputations just to check if the requested reputation does not exist.