Update contracts to solidity 0.8.x #1053
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
area
force-pushed
the
maint/major-upgrades
branch
from
cf302ab to
ce2eedc
Compare
Merged
kronosapiens
force-pushed
the
maint/solidity080
branch
3 times, most recently
from
54d8444 to
295341a
Compare
kronosapiens
reviewed
Feb 7, 2023
|
Looking at it, I would actually update the maths in a separate PR, it's a lot more changes and will make this PR more difficult to review. |
kronosapiens
force-pushed
the
maint/solidity080
branch
from
989ecdd to
64bb223
Compare
kronosapiens
previously approved these changes
Feb 9, 2023
|
@area I'm satisfied with this PR, are you ready to take it off draft? |
kronosapiens
force-pushed
the
maint/solidity080
branch
2 times, most recently
from
8a42ed7 to
3f11fc6
Compare
kronosapiens
approved these changes
Feb 17, 2023
kronosapiens
previously approved these changes
Feb 21, 2023
kronosapiens
previously approved these changes
Mar 9, 2023
area
force-pushed
the
maint/solidity080
branch
4 times, most recently
from
bbc784e to
1b90fcd
Compare
area
force-pushed
the
maint/solidity080
branch
6 times, most recently
from
8c11df8 to
f4ab9f3
Compare
area
force-pushed
the
maint/solidity080
branch
2 times, most recently
from
8101379 to
238fb06
Compare
area
force-pushed
the
maint/solidity080
branch
2 times, most recently
from
39a000c to
fb6db8a
Compare
kronosapiens
approved these changes
Mar 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on top of #1052, so no merging yet!Most non-trivial changes were simply to deal with overflowing arithmetic which we had in a few places unwittingly, but I don't think they've affected anything. A couple of times in the mining contract, and once in the patricia tree. The former has been solved by additional appropriate guards. The latter has been solved by cribbing an alternative line from a slightly updated version of the implementation, but I haven't worked through all the negations etc in order to satisfy myself that it's (basically) the same.
Optional inclusion in this PR: removing all instances of
.addand.sub, as solidity now does that itself unless you use theunchecked {}block?