From 24c6cd80c3b44c5c9a33733e2524afb3e015ee92 Mon Sep 17 00:00:00 2001 From: dylan_DPC Date: Mon, 30 Dec 2019 17:29:03 +0530 Subject: [PATCH 1/4] stabilise remove_item --- src/liballoc/vec.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/liballoc/vec.rs b/src/liballoc/vec.rs index a27a13847d6a2..73c310bb2bfed 100644 --- a/src/liballoc/vec.rs +++ b/src/liballoc/vec.rs @@ -1696,7 +1696,6 @@ impl Vec { /// # Examples /// /// ``` - /// # #![feature(vec_remove_item)] /// let mut vec = vec![1, 2, 3, 1]; /// /// vec.remove_item(&1); From 0a739ce0a5200f2d1360fef126a93b5c1e8205ba Mon Sep 17 00:00:00 2001 From: dylan_DPC Date: Mon, 30 Dec 2019 17:57:00 +0530 Subject: [PATCH 2/4] remove usage of feature gate --- src/librustc/lib.rs | 1 - src/librustdoc/lib.rs | 1 - src/tools/compiletest/src/main.rs | 1 - 3 files changed, 3 deletions(-) diff --git a/src/librustc/lib.rs b/src/librustc/lib.rs index ce8263f81a72f..37761c17f5243 100644 --- a/src/librustc/lib.rs +++ b/src/librustc/lib.rs @@ -50,7 +50,6 @@ #![feature(thread_local)] #![feature(trace_macros)] #![feature(trusted_len)] -#![feature(vec_remove_item)] #![feature(stmt_expr_attributes)] #![feature(integer_atomics)] #![feature(test)] diff --git a/src/librustdoc/lib.rs b/src/librustdoc/lib.rs index c8a32306194df..2effbdaec6b5d 100644 --- a/src/librustdoc/lib.rs +++ b/src/librustdoc/lib.rs @@ -10,7 +10,6 @@ #![feature(nll)] #![feature(set_stdio)] #![feature(test)] -#![feature(vec_remove_item)] #![feature(ptr_offset_from)] #![feature(crate_visibility_modifier)] #![feature(const_fn)] diff --git a/src/tools/compiletest/src/main.rs b/src/tools/compiletest/src/main.rs index 487c1d5fb93a6..da1e3760e010d 100644 --- a/src/tools/compiletest/src/main.rs +++ b/src/tools/compiletest/src/main.rs @@ -1,6 +1,5 @@ #![crate_name = "compiletest"] #![feature(test)] -#![feature(vec_remove_item)] #![deny(warnings)] extern crate test; From 6bec8e997270bed18546b350336d88879b91ff78 Mon Sep 17 00:00:00 2001 From: dylan_DPC Date: Mon, 6 Jan 2020 20:37:49 +0530 Subject: [PATCH 3/4] stabilise it --- src/liballoc/vec.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/liballoc/vec.rs b/src/liballoc/vec.rs index 73c310bb2bfed..bc0cd6eff3708 100644 --- a/src/liballoc/vec.rs +++ b/src/liballoc/vec.rs @@ -1702,7 +1702,7 @@ impl Vec { /// /// assert_eq!(vec, vec![2, 3, 1]); /// ``` - #[unstable(feature = "vec_remove_item", reason = "recently added", issue = "40062")] + #[stable(feature = "vec_remove_item", since = "1.42.0")] pub fn remove_item(&mut self, item: &V) -> Option where T: PartialEq, From 503d06b90dfd8f6055c586c488dbd3a741e9f0c2 Mon Sep 17 00:00:00 2001 From: dylan_DPC Date: Mon, 6 Jan 2020 23:28:47 +0530 Subject: [PATCH 4/4] oh the one that was left behind --- src/liballoc/tests/lib.rs | 1 - 1 file changed, 1 deletion(-) diff --git a/src/liballoc/tests/lib.rs b/src/liballoc/tests/lib.rs index c1ae67a1a339f..3fdee8bbfdf10 100644 --- a/src/liballoc/tests/lib.rs +++ b/src/liballoc/tests/lib.rs @@ -11,7 +11,6 @@ #![feature(associated_type_bounds)] #![feature(binary_heap_into_iter_sorted)] #![feature(binary_heap_drain_sorted)] -#![feature(vec_remove_item)] use std::collections::hash_map::DefaultHasher; use std::hash::{Hash, Hasher};