Skip to content
This repository has been archived by the owner on Jan 13, 2023. It is now read-only.

Improve scene reference usability with lists #8 #13

Closed
wants to merge 1 commit into from
Closed

Improve scene reference usability with lists #8 #13

wants to merge 1 commit into from

Conversation

joaoborks
Copy link

This is my proposal of how to improve usability with lists. As pointed out by @Tymski on #8, the foldouts do not help readability in lists. Personally, I don't think they help even in standard fields. So this PR will make the inspector display more compact, like this:

sceneLoader

As an attempt to solve this:

oldSceneLoader

@JarrydHuntley
Copy link

In our project we have a scriptable object that has a list of scene references for each scene in the game. We have 130 scenes in total, and with the default code the property drawer caused it to be extremely slow and unusable.

@joaoborks' patch fixes all of our performance issues, on top of making the interface much more usable.

Totally has my vote approving this PR 👍🏿

@starikcetin
Copy link
Collaborator

starikcetin commented Jun 9, 2021

@JohannesMP Seems like this is what people want. I will merge it if you are OK with it as well.

@starikcetin starikcetin linked an issue Jun 9, 2021 that may be closed by this pull request
@mfdeveloper
Copy link

mfdeveloper commented Jun 27, 2022

Hello @JohannesMP !

Will you merge it ? I just figure out that latest versions of Unity 2020.3.30+ on macOS show UI problems on inspector, like this one below:

Screenshot 2022-06-27 at 17 47 06

In my case, I'm using a list of structs/POCO's. Because of this "glitch", I can't attach the scene reference on inspector 😢

Could you help me? I think that this MR could fix this issue, right?

PS: @joaoborks Meanwhile, could you deploy this MR to your [upm] branch? With this, I could use your fork reference directly on manifest.json

@joaoborks
Copy link
Author

@mfdeveloper I've pushed these changes to my fork's upm branch

@mfdeveloper
Copy link

Hellooo @joaoborks ! Thank you so much for your and update reply

I updated the link to yours [upm] fork branch, but unfortunately the result is the same 😢

Screenshot 2022-07-19 at 22 55 52

Doesn't matter when I put the script that contains SceneReference field, the component panel title (or the "Add Component" in this case) stays on top of it.

Could you help me with that, please?

@joaoborks
Copy link
Author

Are you still on Unity 2020.3.30?

@mfdeveloper
Copy link

@joaoborks So sorry for my huge delay to reply to you 😅
Thus, I got this problem only on 2020.x.x. I updated to Unity 2021.x and this problem doesn't happen :)

@nehvaleem
Copy link

how it is going? I would totally appreciate it if this PR gets merged :)

@joaoborks joaoborks closed this by deleting the head repository Dec 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Usability issues with lists
5 participants