Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add checks on arguments #3

Closed
JoFrhwld opened this issue Sep 18, 2023 · 0 comments · Fixed by #10
Closed

Add checks on arguments #3

JoFrhwld opened this issue Sep 18, 2023 · 0 comments · Fixed by #10

Comments

@JoFrhwld
Copy link
Owner

There should be checks on the arguments passed to density_area() and density_polygons(), e.g.

  • x, y need to be numeric
    • functions should error with helpful message
  • x, y should be the same length
    • functions should error with helpful message
  • x, y should have a minimum length.
    • Unsure what the length should be?
    • functions should return a 0 length tibble with a warning to safely work with tidyverse. e.g. a data frame gets grouped, and most groups have enough tokens, but one doesn’t.
  • probs should be >0 and <1.
    • functions should error with helpful message
@JoFrhwld JoFrhwld linked a pull request Sep 26, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant