Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

intensity cutoff occurs before start of AY segment #33

Open
scjs opened this issue Jul 13, 2014 · 0 comments
Open

intensity cutoff occurs before start of AY segment #33

scjs opened this issue Jul 13, 2014 · 0 comments
Labels
bug Something broke

Comments

@scjs
Copy link
Contributor

scjs commented Jul 13, 2014

I have an AY vowel token that causes getTimeOfF1Maximum() to raise a ValueError, because trimmedFormants returns an empty list.

I think this is happening because the maximum intensity is very early in the intensity curve, and the intensity drops off right away, so getIntensityCutoff() chooses a cutoff that only spans the first few intensity frames. This is an issue because the timestamps for those intensity frames are used to trim the formant frames, and the formant frames may start later than the intensity frames (there's no formant measurements at the very edges). In my token, the first formant frame is 7ms after the first intensity frame, so if the intensity cutoff occurs before the 7th 1ms intensity frame, no formant frames will be returned by trimFormants().

One way to fix this which might address #22 also, would be to take measurements in a way that intensity and formant frames are synced up. Or, a smaller fix could be made in faav(), modifyIntensityCutoff(), or getTimeOfF1Maximum() to make sure that the end_cutoff time is not before the first formant frame.

@chrisbrickhouse chrisbrickhouse added the bug Something broke label Sep 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something broke
Projects
None yet
Development

No branches or pull requests

2 participants