-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for other time-zones #8
Comments
Primarily because it hasn't been needed since any code that is going to fail will fail in any timezone which supports daylight saving time (assuming your tests test a reasonable number of times). You're welcome to add more if you think it would be useful for your use case! That being said, EDT (assuming that's Eastern Daylight Time) is the timezone used by US/Eastern for part of the year, so that is one that is already supported. |
Sorry, I was not quite correct... any buggy code will fail when either in a timezone with DST, or when ran in two different timezones, depending on what the bug is, so as long as there's more than one timezone supported, and at least one uses DST, any bug should be reproducible. |
I've had code that in principle could fail with any positive TZ offset, but in practice fails in Australia but not Europe because the cases are less likely to show up when it's only a few hours positive. I suggest that including an Australian timezone (some of which also have half-hour offsets) would therefore be prudent. |
That's a reasonably different timezone than others, I've added |
I added a custom timezone (always BST, for testing daylight savings in the UK regardless of system time) like this:
|
Can you at least add the east and west extremes? I've got code that needs to check if a local date fits on any of the local calendar dates covered by a UTC interval, and there are edge cases around the extremes As an example, if I have a UTC interval from
|
@jacobwahoo That's a compelling reason to need those! A PR would be welcome, I think import.js has comments on how to import a different timezone, from a Linux system, however I'm on Windows at the moment, so if you want to take a stab at it, feel free! |
All UTC timezones are now included thanks to @jacobwahoo as of |
Why is there support only for 3 timezones? Why not support all of them? I have an issue with my server being in EDT timezone, and I'd be glad to check everything will be fine with this specific timezone.
The text was updated successfully, but these errors were encountered: