Optimize check for missing fields in deserialization #3862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandwwraith
requested changes
Oct 21, 2020
There was a problem hiding this comment.
Also, it seems your commit message refers to issues in the Kotlin repo, not kotlinx.serialization one. You can paste full links instead.
Notice that SerializationPluginBytecodeListingTestGenerated will likely fail after your changes due to changed bytecode shape. You can delete testData/codegen/basic.txt and re-run test to generate new bytecode
...tion-compiler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/JVMCodegenUtil.kt
Outdated
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
sandwwraith
requested changes
Oct 29, 2020
...iler/src/org/jetbrains/kotlinx/serialization/compiler/backend/jvm/SerializableCodegenImpl.kt
Outdated
Show resolved
Hide resolved
...ation-compiler/src/org/jetbrains/kotlinx/serialization/compiler/resolve/NamingConventions.kt
Outdated
Show resolved
Hide resolved
sandwwraith
reviewed
Nov 10, 2020
...ion-compiler/src/org/jetbrains/kotlinx/serialization/compiler/backend/ir/GeneratorHelpers.kt
Show resolved
Hide resolved
...piler/src/org/jetbrains/kotlinx/serialization/compiler/backend/ir/SerializableIrGenerator.kt
Outdated
Show resolved
Hide resolved
...piler/src/org/jetbrains/kotlinx/serialization/compiler/backend/ir/SerializableIrGenerator.kt
Show resolved
Hide resolved
sandwwraith
approved these changes
Nov 23, 2020
shanshin
force-pushed
the
rr/shanshin/serial-optimize-check-fields-662
branch
from
c3b94a6
to
a79d8d1
Compare
Join origins of serialization plugin Fixes Kotlin/kotlinx.serialization#662 Kotlin/kotlinx.serialization#657
erokhins
pushed a commit
that referenced
this pull request
Dec 14, 2020
* 0634351 - (HEAD -> master, tag: build-1.4.30-dev-3308, origin/master, origin/HEAD) Introduce pathString/absolute/absolutePathString (vor 18 Stunden) <Ilya Gorbunov> * 84f5a29 - Allow passing null parent directory to createTempFile/Directory (vor 18 Stunden) <Ilya Gorbunov> * 64d85f2 - Relax writeText/appendText parameter type to CharSequence (vor 18 Stunden) <Ilya Gorbunov> * 2ee8bf7 - (tag: build-1.4.30-dev-3302, origin/rr/demiurg906/platform-switch) Add fastutil dependency for 202 and higher platforms (vor 2 Tagen) <Pavel Punegov> * f668e90 - Build: unmute passed tests (vor 2 Tagen) <Dmitriy Novozhilov> * e7d305b - Build: mute failing stepping tests (vor 2 Tagen) <Dmitriy Novozhilov> * 78c786d - Build: Mute failing goto declaration tests (vor 2 Tagen) <Dmitriy Novozhilov> * 33b545a - Build: Mute failing gradle import with android tests (vor 2 Tagen) <Dmitriy Novozhilov> * 85c5932 - [DEBUGGER] Temporary mute AbstractKotlinEvaluateExpressionTest (vor 2 Tagen) <Dmitriy Novozhilov> * 3d33ea7 - Use absolute paths to locate existed projects to open in AbstractConfigureKotlinTest (vor 2 Tagen) <Vladimir Dolzhenko> * 124888e - Revert back AddFunctionParametersFix test data output for 201- (vor 2 Tagen) <Vladimir Dolzhenko> * e251a9b - Build: fix finding layout-api jar in parcelize box test due to platform change (vor 2 Tagen) <Dmitriy Novozhilov> * cc1a0bf - [FE] Update testdata (vor 2 Tagen) <Dmitriy Novozhilov> * 17e6e88 - Fixed AddFunctionParametersFix test data output (vor 2 Tagen) <Vladimir Dolzhenko> * 406e863 - [FE] Fix creating location of compiler errors in CLI (vor 2 Tagen) <Dmitriy Novozhilov> * dc364b8 - Remove useless @author comment (vor 2 Tagen) <Dmitriy Novozhilov> * 95e5ea4 - temporary ignore/disable tests (vor 2 Tagen) <Vladimir Dolzhenko> * 02f71a6 - [FE] Disable `SKIP_DEBUG` flag when building java model from binaries (vor 2 Tagen) <Dmitriy Novozhilov> * bf1abed - Build: add shadowing processor for core.xml in embeddable compiler (vor 2 Tagen) <Dmitriy Novozhilov> * ad953b6 - Build: remove redundant bunch TODO's (vor 2 Tagen) <Dmitriy Novozhilov> * 986ab9c - Build: remove useless .as40 files (vor 2 Tagen) <Dmitriy Novozhilov> * 1b559fe - Don't set KOTLIN_BUNDLED in unit tests (vor 2 Tagen) <Dmitriy Novozhilov> * 7396abf - Build: add fastutil dependency to scripting tests (vor 2 Tagen) <Dmitriy Novozhilov> * 5ab9710 - Remove `./local` directory from CodeConformanceTest (vor 2 Tagen) <Dmitriy Novozhilov> * d3ef0eb - Build: register missing TreeAspect service in KtParsingTestCase (vor 2 Tagen) <Dmitriy Novozhilov> * 6871983 - Build: update asm version in kotlinp (vor 2 Tagen) <Dmitriy Novozhilov> * dc35a13 - Build: remove useless bunch files (vor 2 Tagen) <Dmitriy Novozhilov> * 46fcc7d - Build: fix registration of `ClassFileDecompilers` extension (vor 2 Tagen) <Dmitriy Novozhilov> * 48cbb74 - Build: drop deprecated extension point used in test of old j2k (vor 2 Tagen) <Dmitriy Novozhilov> * d887814 - Build: fix compilation of :libraries:tools:kotlin-maven-plugin-test (vor 2 Tagen) <Dmitriy Novozhilov> * 4779092 - Build: fix API differences between 201 and 202 in idea performance tests (vor 2 Tagen) <Dmitriy Novozhilov> * 2a053c2 - Build: fix API differences between 201 and 202 in scratch tests (vor 2 Tagen) <Dmitriy Novozhilov> * d50d56f - Build: fix API differences between 201 and 202 in NewKotlinFileAction (vor 2 Tagen) <Dmitriy Novozhilov> * e4e28a5 - Build: update grovy dependencies in :compiler:tests-spec (vor 2 Tagen) <Dmitriy Novozhilov> * 07dd917 - Build: change 202 platform version (vor 2 Tagen) <Dmitriy Novozhilov> * eeb9b32 - Switch to 202 platform (vor 2 Tagen) <Dmitriy Novozhilov> * 89bba93 - (tag: build-1.4.30-dev-3300) Introduce GetScriptingClassByClassLoader interface (vor 2 Tagen) <Ilya Muradyan> * 65ce7cd - Fix path for Windows in Fibonacci test (vor 2 Tagen) <Ilya Muradyan> * 78e607c - (tag: build-1.4.30-dev-3294) Value classes: Support @JvmName annotation on functions with inline (vor 2 Tagen) <Ilmir Usmanov> * 871912f - (tag: build-1.4.30-dev-3289) Value Classes: Increase BINARY_STUB_VERSION after decompiler changes (vor 2 Tagen) <Ilmir Usmanov> * 05c4dfe - Value classes: Use 'value' keyword instead of 'inline' in stub dumps (vor 2 Tagen) <Ilmir Usmanov> * 9b9c43b - Value classes: Change relevant diagnostic to say 'value class' (vor 2 Tagen) <Ilmir Usmanov> * ca3e7cf - Value classes: Report lacking @JvmInline only on JVM backend (vor 2 Tagen) <Ilmir Usmanov> * 92f1681 - Value classes: treat @JvmInline value classes as inline classes (vor 2 Tagen) <Ilmir Usmanov> * 6c68660 - Value classes: Render 'value' before class (vor 2 Tagen) <Ilmir Usmanov> * f158411 - Value classes: Increase JVM metadata version to distinguish (vor 2 Tagen) <Ilmir Usmanov> * 361ed11 - Value classes: Add isValue property to class descriptors (vor 2 Tagen) <Ilmir Usmanov> * 8eff3a6 - Value classes: Increase stub version due to changes in the parser (vor 2 Tagen) <Ilmir Usmanov> * 11b2a07 - Value classes: Support 'value' modifier in parser (vor 2 Tagen) <Ilmir Usmanov> * d5979ff - (tag: build-1.4.30-dev-3286) FIR IDE: add tests for checking module invalidation (vor 2 Tagen) <Ilya Kirillov> * 2fb4a91 - FIR IDE: fix module invalidation algorithm (vor 2 Tagen) <Ilya Kirillov> * 519f154 - FIR IDE: separate logic of TestProjectStructure from AbstractFirMultiModuleLazyResolveTest (vor 2 Tagen) <Ilya Kirillov> * 3515cd5 - FIR IDE: use PersistentMap to store FromModuleViewSessionCache mappings (vor 2 Tagen) <Ilya Kirillov> * 76c0dc7 - (tag: build-1.4.30-dev-3278) FIR IDE: add property support for incremental analysis (vor 3 Tagen) <Ilya Kirillov> * 953dba8 - FIR IDE: move withFirDeclaration to LowLevelFirApiFacade (vor 3 Tagen) <Ilya Kirillov> * b4d63b9 - FIR IDE: add docs for LowLevelFirApiFacade functions (vor 3 Tagen) <Ilya Kirillov> * 93648e6 - FIR IDE: use mor specific exception in EntityWasGarbageCollectedException (vor 3 Tagen) <Ilya Kirillov> * 65a7ee5 - FIR IDE: remove duplicating withFirResolvedToBodyResolve (vor 3 Tagen) <Ilya Kirillov> * 3141fea - FIR IDE: get rid of LowLevelFirApiFacade object (vor 3 Tagen) <Ilya Kirillov> * a206eca - (tag: build-1.4.30-dev-3272) JVM_IR KT-43611 report signature clash on private interface members (vor 3 Tagen) <Dmitry Petrov> * fd935b7 - (tag: build-1.4.30-dev-3270) [TEST] Move generated js compiler tests to `test-gen` directories (vor 3 Tagen) <Dmitriy Novozhilov> * 77ed51b - (tag: build-1.4.30-dev-3266) [JS IR] Add message for for enabling option for overwriting reachable nodes (vor 3 Tagen) <Ilya Goncharov> * 908732b - (tag: build-1.4.30-dev-3257, tag: build-1.4.30-dev-3254) [TEST] Move generated visualizer tests to `test-gen` directories (vor 3 Tagen) <Dmitriy Novozhilov> * eca769f - [TEST] Move generated fir tests to `test-gen` directories (vor 3 Tagen) <Dmitriy Novozhilov> * 1ee3828 - [TEST] Move generated compiler tests to `test-gen` directory (vor 3 Tagen) <Dmitriy Novozhilov> * 524419a - (tag: build-1.4.30-dev-3240) IC Mangling: Use new mangling scheme for range tests (vor 3 Tagen) <Ilmir Usmanov> * 6381d97 - JVM_IR: compute classId on IR structures (vor 3 Tagen) <Georgy Bronnikov> * ee1e05f - (tag: build-1.4.30-dev-3225) KT-42151 fix type arguments in local class constructor reference types (vor 4 Tagen) <Dmitry Petrov> * b2b8562 - (tag: build-1.4.30-dev-3221) Properly extract JVM version in kapt (vor 4 Tagen) <Mikhael Bogdanov> * 9ed5b8f - (tag: build-1.4.30-dev-3220) IC & Coroutines: Do not box suspend operator fun invoke receiver (vor 4 Tagen) <Ilmir Usmanov> * 4e33421 - IC & Coroutines: Unbox inline class parameter of suspend lambda (vor 4 Tagen) <Ilmir Usmanov> * eba260f - IC & Coroutines: Unbox inline classes of suspend lambdas (vor 4 Tagen) <Ilmir Usmanov> * 0a0b5b5 - (tag: build-1.4.30-dev-3218) [FIR DFA] Don't consider anonymous object as stable initializer to bind (vor 4 Tagen) <Mikhail Glukhikh> * 1dc8973 - [FIR] Fix WRONG_IMPLIES_CONDITION problem in DFA model (vor 4 Tagen) <Mikhail Glukhikh> * 7fd96f5 - (tag: build-1.4.30-dev-3211) Fix annotation spelling in docs (vor 4 Tagen) <Ilya Gorbunov> * db9f301 - [FE] Make DiagnosticFactory.name not null (vor 4 Tagen) <Dmitriy Novozhilov> * 94ce56b - (tag: build-1.4.30-dev-3199, tag: build-1.4.30-dev-3189, origin/master-for-ide) Minor. Add words to project dictionary (vor 4 Tagen) <Dmitriy Dolovov> * c741284 - [Commonizer] Stricter processing of forward declarations (vor 4 Tagen) <Dmitriy Dolovov> * eca231a - [Commonizer] Extract CIR classifiers cache from the root node (vor 4 Tagen) <Dmitriy Dolovov> * 8d9abed - [Commonizer] Minor. More specific upper bounds for CirNodeWithClassId (vor 4 Tagen) <Dmitriy Dolovov> * d4b0bf4 - (tag: build-1.4.30-dev-3184) [FIR] Make DEFAULT positioning strategy public, drop duplicated one (vor 4 Tagen) <Mikhail Glukhikh> * 97c1a3f - Simplify FirSupertypeInitializedWithoutPrimaryConstructor checker (vor 4 Tagen) <Mikhail Glukhikh> * bf2b318 - Simplify FirSupertypeInitializedInInterfaceChecker (vor 4 Tagen) <Mikhail Glukhikh> * 12726cd - FIR light builder: use type reference node as FirTypeRef source (vor 4 Tagen) <Mikhail Glukhikh> * d5f17ea - Simplify FirDelegationInInterfaceChecker (vor 4 Tagen) <Mikhail Glukhikh> * b673996 - Simplify source operations in FirAnnotationArgumentChecker (vor 4 Tagen) <Mikhail Glukhikh> * 1c71e64 - [FIR] Create string interpolating call even for single argument (vor 4 Tagen) <Mikhail Glukhikh> * 915a66f - [FIR] Introduce & use "multiplexing" SourceElementPositioningStrategy (vor 4 Tagen) <Mikhail Glukhikh> * f3334b0 - FIR checkers: simplify FirSupertypeInitializedWithoutPrimaryConstructor (vor 4 Tagen) <Mikhail Glukhikh> * 58301d8 - FIR exposed visibility checkers: use positioning strategy (vor 4 Tagen) <Mikhail Glukhikh> * f095a33 - FIR checkers: extract getChildren(), simplify findSuperTypeDelegation() (vor 4 Tagen) <Mikhail Glukhikh> * 1e3621a - FIR checkers: simplify hasPrimaryConstructor by source element check (vor 4 Tagen) <Mikhail Glukhikh> * 0838ab7 - FIR checkers: simplify hasVal / hasVar source element checks (vor 4 Tagen) <Mikhail Glukhikh> * c6b703b - Simplify LighterASTNode.toFirLightSourceElement (vor 4 Tagen) <Mikhail Glukhikh> * 037c505 - Unbind general FirDiagnostic from PsiFile & PsiElement (vor 4 Tagen) <Mikhail Glukhikh> * 68b748e - Rename DebugInfoUtil.java to DebugInfoUtil.kt, same with AnalyzingUtils (vor 4 Tagen) <Mikhail Glukhikh> * 6f8947d - Extract UnboundDiagnostic, DiagnosticFactory/Renderer to frontend-common (vor 4 Tagen) <Mikhail Glukhikh> * 52a07e3 - [FIR] Remove D_I_EXPRESSION_TYPE from qualified calls in spec test data (vor 4 Tagen) <Mikhail Glukhikh> * 558ac16 - Create FIR fake source element for checked safe call subject (vor 4 Tagen) <Mikhail Glukhikh> * 2592eed - [FIR TEST] More precise control of source kind in createDebugInfo (vor 4 Tagen) <Mikhail Glukhikh> * 82c5cef - Update test data in FIR diagnostic spec tests (vor 4 Tagen) <Mikhail Glukhikh> * e7e162c - [FIR TEST] Filter some particular tokens during createDebugInfo (vor 4 Tagen) <Mikhail Glukhikh> * c602ccb - Create FIR fake source element for vararg argument expression (vor 4 Tagen) <Mikhail Glukhikh> * fa3f805 - Support FirDiagnostic.isValid properly (vor 4 Tagen) <Mikhail Glukhikh> * c7ae176 - [FIR] Inherit FIR with parameter renderer from the old parameter renderer (vor 4 Tagen) <Mikhail Glukhikh> * 3dec848 - [FIR] Implement light tree DECLARATION_NAME & SIGNATURE strategies (vor 4 Tagen) <Mikhail Glukhikh> * 42c59f7 - [FIR] Enhance light tree DEFAULT strategy for objects to cover header only (vor 4 Tagen) <Mikhail Glukhikh> * d844b33 - [FIR] Implement light tree CONSTRUCTOR_DELEGATION_CALL strategy (vor 4 Tagen) <Mikhail Glukhikh> * 8320a29 - [FIR] Implement light tree VAL_VAR strategy as an example (vor 4 Tagen) <Mikhail Glukhikh> * 1795c4f - Implement common Diagnostic(Factory/Renderer) in related FIR classes (vor 4 Tagen) <Mikhail Glukhikh> * d47e163 - Convert DiagnosticFactory.java to Kotlin (vor 4 Tagen) <Mikhail Glukhikh> * 84f3a4b - Rename DiagnosticFactory.java to DiagnosticFactory.kt (vor 4 Tagen) <Mikhail Glukhikh> * 9040999 - Convert Diagnostic.java to Kotlin (vor 4 Tagen) <Mikhail Glukhikh> * b6cfcc6 - Rename Diagnostic.java to Diagnostic.kt (vor 4 Tagen) <Mikhail Glukhikh> * d942780 - [FIR] Introduce LightTreePositioningStrategy (vor 4 Tagen) <Mikhail Glukhikh> * 1cb2aea - FirSourceElement: introduce common 'treeStructure' property (vor 4 Tagen) <Mikhail Glukhikh> * 3a2b155 - FirSourceElement: introduce common 'lighterASTNode' property (vor 4 Tagen) <Mikhail Glukhikh> * 6abd656 - (tag: build-1.4.30-dev-3169) [IR] dumpKotlinLike: update testdata after rebase (vor 5 Tagen) <Zalim Bashorov> * 0d5a0b2 - [IR] KotlinLikeDumper: add a note about some conventions used for TODO comments (vor 5 Tagen) <Zalim Bashorov> * c004269 - [IR] KotlinLikeDumper: unify and add more comments for the cases when used a syntax which is invalid in Kotlin (vor 5 Tagen) <Zalim Bashorov> * 5a75505 - [IR] dumpKotlinLike: add a comment about some conventions which could be unclear (vor 5 Tagen) <Zalim Bashorov> * 69f0f4e - [IR] update testdata: unify printing custom/non-standard modifiers (vor 5 Tagen) <Zalim Bashorov> * 90fdfbd - [IR] KotlinLikeDumper: unify printing custom/non-standard modifiers (vor 5 Tagen) <Zalim Bashorov> * 57cb8f9 - [IR] update testdata: don't use "D" suffix on double constants (vor 5 Tagen) <Zalim Bashorov> * 73771a3 - [IR] KotlinLikeDumper: don't use "D" suffix on double constants (vor 5 Tagen) <Zalim Bashorov> * 7df6575 - [IR] update testdata: unify representation for error nodes (vor 5 Tagen) <Zalim Bashorov> * ef9a901 - [IR] KotlinLikeDumper: unify representation for error nodes (vor 5 Tagen) <Zalim Bashorov> * f8690d0 - [IR] KotlinLikeDumper: minor, collapse an `if` to helper function and add few more todos (vor 5 Tagen) <Zalim Bashorov> * c680407 - [IR] dumpKotlinLike: add testdata for FIR tests (vor 5 Tagen) <Zalim Bashorov> * d7bd424 - [IR] dumpKotlinLike: don't crash when type argument is null (vor 5 Tagen) <Zalim Bashorov> * dec067a - [IR] stop overwriting testdata for dumpKotlinLike and use assertEqualsToFile (vor 5 Tagen) <Zalim Bashorov> * 43ee50b - [IR] update testdata after rebase (vor 5 Tagen) <Zalim Bashorov> * 2773e4b - [IR] KotlinLikeDumper.kt -> dumpKotlinLike.kt (vor 5 Tagen) <Zalim Bashorov> * 36591ba - [IR] KotlinLikeDumper: replace all usages of commentBlockH with commentBlock (vor 5 Tagen) <Zalim Bashorov> * ad0f154 - [IR] add new testdata after rebase (vor 5 Tagen) <Zalim Bashorov> * f9fe82e - [IR] KotlinLikeDumper: process specially when IrElseBranch's condition is not `true` constant (vor 5 Tagen) <Zalim Bashorov> * 503370c - [IR] update testdata: escape special symbols in Char and String constant values (vor 5 Tagen) <Zalim Bashorov> * 0f10b5e - [IR] KotlinLikeDumper: escape special symbols in Char and String constant values (vor 5 Tagen) <Zalim Bashorov> * 92dda5c - [IR] KotlinLikeDumper.kt: cleanup (vor 5 Tagen) <Zalim Bashorov> * 5b0efe2 - [IR] KotlinLikeDumper: rearrange methods (vor 5 Tagen) <Zalim Bashorov> * d9dbc01 - [IR] KotlinLikeDumper: `p.print("")` -> `p.printIndent()` (vor 5 Tagen) <Zalim Bashorov> * c7d9b7a - [IR] KotlinLikeDumper: rearrange methods (vor 5 Tagen) <Zalim Bashorov> * 76e959e - [IR] KotlinLikeDumper: minor, update some comments (vor 5 Tagen) <Zalim Bashorov> * e94528f - [IR] update testdata: print class name for callable references without receivers (vor 5 Tagen) <Zalim Bashorov> * b6e37c1 - [IR] KotlinLikeDumper: print class name for callable references without receivers (vor 5 Tagen) <Zalim Bashorov> * 2dbd784 - [IR] update testdata: print `else -> ...` (vor 5 Tagen) <Zalim Bashorov> * 14dabed - [IR] KotlinLikeDumper.kt: move branch support to corresponding visit* methods (vor 5 Tagen) <Zalim Bashorov> * 8f155c2 - [IR] update testdata: better support for callable references (vor 5 Tagen) <Zalim Bashorov> * 0d3d618 - [IR] KotlinLikeDumper: better support for callable references (vor 5 Tagen) <Zalim Bashorov> * 87eb06a - [IR] update testdata: improve annotations rendering in case when argument was not provided and there is default value (vor 5 Tagen) <Zalim Bashorov> * a34a311 - [IR] update testdata: support annotations on parameters (vor 5 Tagen) <Zalim Bashorov> * 182cb52 - [IR] KotlinLikeDumper: various changes for value and type params (vor 5 Tagen) <Zalim Bashorov> * 5cb2572 - [IR] update testdata: better support for enum and object accesses (vor 5 Tagen) <Zalim Bashorov> * 1fd12b7 - [IR] KotlinLikeDumper: better support for enum and object accesses (vor 5 Tagen) <Zalim Bashorov> * 635cb44 - [IR] update testdata: support IrDynamic* nodes (vor 5 Tagen) <Zalim Bashorov> * 82839e6 - [IR] KotlinLikeDumper: support IrDynamic* nodes (vor 5 Tagen) <Zalim Bashorov> * cdc7430 - [IR] add testdata for irJsText (vor 5 Tagen) <Zalim Bashorov> * 68b17fe - [IR] KotlinLikeDumper: add more visit* to implement (vor 5 Tagen) <Zalim Bashorov> * 4fb762e - [IR] update testdata: minor updates for error nodes (vor 5 Tagen) <Zalim Bashorov> * b129788 - [IR] KotlinLikeDumper: minor updates for error nodes (vor 5 Tagen) <Zalim Bashorov> * a128cdc - [IR] KotlinLikeDumper: add more TODOs and remove some obsolete ones (vor 5 Tagen) <Zalim Bashorov> * bf20720 - [IR] KotlinLikeDumper: reformat (vor 5 Tagen) <Zalim Bashorov> * ad5df79 - [IR] KotlinLikeDumper: merge Break & Continue (vor 5 Tagen) <Zalim Bashorov> * 64b4240 - [IR] update testdata: print a parameter in catch (vor 5 Tagen) <Zalim Bashorov> * 2775c89 - [IR] KotlinLikeDumper: print a parameter in catch (vor 5 Tagen) <Zalim Bashorov> * 5c8a93c - [IR] update testdata: support labels on loops, break & continue (vor 5 Tagen) <Zalim Bashorov> * 9daa86c - [IR] KotlinLikeDumper: support labels on loops, break & continue (vor 5 Tagen) <Zalim Bashorov> * 21da2b0 - [IR] update testdata: print whole string concatenation at one line (vor 5 Tagen) <Zalim Bashorov> * 91c9d9d - [IR] KotlinLikeDumper: print whole string concatenation at one line (vor 5 Tagen) <Zalim Bashorov> * a6b4089 - [IR] update testdata: super and receiver for field accesses (vor 5 Tagen) <Zalim Bashorov> * 029ee6f - [IR] KotlinLikeDumper: super and receiver on field accesses (vor 5 Tagen) <Zalim Bashorov> * 0bf587a - [IR] KotlinLikeDumper: deduplicate code between IrDelegatingConstructorCall and IrEnumConstructorCall (vor 5 Tagen) <Zalim Bashorov> * e56787c - [IR] update testdata: IrInstanceInitializerCall (vor 5 Tagen) <Zalim Bashorov> * 26dd009 - [IR] KotlinLikeDumper: change rendering for IrInstanceInitializerCall (vor 5 Tagen) <Zalim Bashorov> * ab8188b - [IR] update testdata: removed extra indentation for function expressions (vor 5 Tagen) <Zalim Bashorov> * cf5ba82 - [IR] KotlinLikeDumper: don't indent function expressions (vor 5 Tagen) <Zalim Bashorov> * 5500b01 - [IR] update testdata: better support for IrEnumConstructorCall and IrEnumEntry (vor 5 Tagen) <Zalim Bashorov> * 602f0dd - [IR] update testdata after using maxBlankLines=1 for Printer (vor 5 Tagen) <Zalim Bashorov> * 6e31889 - [IR] KotlinLikeDumper: support for IrEnumConstructorCall and better rendering for IrEnumEntry (vor 5 Tagen) <Zalim Bashorov> * b518c19 - [IR] update testdata: support for IrDelegatingConstructorCall (vor 5 Tagen) <Zalim Bashorov> * 84d6e43 - [IR] update testdata: print arguments for annotations (vor 5 Tagen) <Zalim Bashorov> * 2a19dc3 - [IR] update testdata: better support for IrConstructorCall (vor 5 Tagen) <Zalim Bashorov> * 197f5ca - [IR] update testdata: better support for IrCall (vor 5 Tagen) <Zalim Bashorov> * ef2adfa - [IR] KotlinLikeDumper: better support for calls and annotations (vor 5 Tagen) <Zalim Bashorov> * fc5c674 - [IR] update testdata (vor 5 Tagen) <Zalim Bashorov> * 6a1ab1b - [IR] KotlinLikeDumper: WIP (vor 5 Tagen) <Zalim Bashorov> * 0294ff4 - [IR] add TODO to RenderIrElement (vor 5 Tagen) <Zalim Bashorov> * a5b224f - [IR] add new testdata after rebase (vor 5 Tagen) <Zalim Bashorov> * 3b1a638 - [IR] update testdata after rebase (vor 5 Tagen) <Zalim Bashorov> * 1c6c996 - [IR] KotlinLikeDumper: fixes after rebase (vor 5 Tagen) <Zalim Bashorov> * 7abd09c - [IR] initial version of dumpKotlinLike (vor 5 Tagen) <Zalim Bashorov> * 8d5facb - [IR] add testdata for dumpKotlinLike (vor 5 Tagen) <Zalim Bashorov> * d2022ab - [IR] hack AbstractIrTextTestCase to test dumpKotlinLike (vor 5 Tagen) <Zalim Bashorov> * 6241f9b - (tag: build-1.4.30-dev-3165) Build: Fix ide plugin maven artifacts publication (vor 5 Tagen) <Vyacheslav Gerasimov> * 8f187f3 - (tag: build-1.4.30-dev-3162) Switch ASM artifact (vor 5 Tagen) <Mikhael Bogdanov> * b5143ba - (tag: build-1.4.30-dev-3161) Optimize check for missing fields in deserialization (#3862) (vor 5 Tagen) <Sergey Shanshin> * f9503ef - (tag: build-1.4.30-dev-3159) [JS IR] Make WITH_RUNTIME imply KJS_WITH_FULL_RUNTIME (vor 5 Tagen) <Svyatoslav Kuzmich> * b0ebb02 - (tag: build-1.4.30-dev-3158) Fix more deprecated configurations and disable fail mode for some tests (vor 5 Tagen) <Bingran> * 858f731 - Update settings script properly, more tests with warning-mode=fail (vor 5 Tagen) <Bingran> * 52c22d8 - MPP plugin: add expectedBy deps to "api" configuration (vor 5 Tagen) <Bingran> * 4bf63a9 - Sort class members to ensure deterministic builds (vor 5 Tagen) <Hung Nguyen> * 07a797c - (tag: build-1.4.30-dev-3155) [IR] Fixed bug with type parameters of referenced constructor (vor 5 Tagen) <Igor Chevdar> * c905461 - (tag: build-1.4.30-dev-3149) Uast: partial fix for reified functions resolve (#3923, KT-41279) (vor 5 Tagen) <Kevin Bierhoff> * 7cc6204 - (tag: build-1.4.30-dev-3144) Minor: update testData (vor 5 Tagen) <Dmitry Petrov> * e5dce9f - KT-42933 inline class backing field can't be static (vor 5 Tagen) <Dmitry Petrov> * f6abc5c - KT-43286 use JVM 1.8 intrinsics for coercible unsigned values only (vor 5 Tagen) <Dmitry Petrov> * 498047e - KT-43562 don't remap static inline class funs as special builtins (vor 5 Tagen) <Dmitry Petrov> * f6c7372 - (tag: build-1.4.30-dev-3141) Fix serializing properties with custom accessors (#3907) (vor 5 Tagen) <Sergey Shanshin> * 7327c20 - (tag: build-1.4.30-dev-3140) FIR: add a resolution mode for property delegates (vor 5 Tagen) <pyos> * 0a5b899 - FIR: more comprehensive substitution of stub types after builder inference (vor 5 Tagen) <Jinseong Jeon> * 30c97e6 - FIR: update unsubstituted return types in builder (vor 5 Tagen) <Jinseong Jeon> * d58e5b1 - Remove unnecessary semi-colons (vor 5 Tagen) <Jinseong Jeon> * a0dd62f - Remove unnecessary expression (vor 5 Tagen) <Jinseong Jeon> * dfc5059 - FIR: reproduce KT-43340 (vor 5 Tagen) <Jinseong Jeon> * c13650f - (tag: build-1.4.30-dev-3131) KT-43511 [Gradle Runner]: run task is not created for top level modules (vor 5 Tagen) <Andrei Klunnyi> * 25a631a - (tag: build-1.4.30-dev-3125) Improved IDE performance tests vega specs (vor 5 Tagen) <Vladimir Dolzhenko> * dcdd69d - (tag: build-1.4.30-dev-3123) Invalidate caches before resolve in AbstractPerformanceHighlightingTest (vor 5 Tagen) <Ilya Kirillov> * 04846ca - (tag: build-1.4.30-dev-3122) Rework checking constraints by presented `OnlyInputTypes` annotation in accordance with changed incorporation mechanism (vor 5 Tagen) <Victor Petukhov> * 0857b9c - Rethink constraints incorporation (vor 5 Tagen) <Victor Petukhov> * 616e40f - Reuse equality constraints during simplification in adding constraints (vor 5 Tagen) <Victor Petukhov> * aabe709 - (tag: build-1.4.30-dev-3116) Value classes: Add @JvmInline annotation to stdlib (vor 5 Tagen) <Ilmir Usmanov> * a710013 - (tag: build-1.4.30-dev-3111) Don't mark testJsTestOutputFileInProjectWithAndroid as flaky in 202 (vor 6 Tagen) <Andrey Uskov> * ee40b3a - (tag: build-1.4.30-dev-3109) Drop redundant fields around AbstractFir2IrLazyFunction (vor 6 Tagen) <Mikhail Glukhikh> * fda5ee7 - Fir2IrLazyPropertyAccessor: make inline iff FIR accessor is inline (vor 6 Tagen) <Mikhail Glukhikh> * d27a0c9 - Extract AbstractFir2IrLazyFunction (base for accessor & simple function) (vor 6 Tagen) <Mikhail Glukhikh> * c03fa59 - Introduce Fir2IrLazyPropertyAccessor (vor 6 Tagen) <Mikhail Glukhikh> * 7117932 - JVM IR: handle JvmStatic in object as module phase (vor 6 Tagen) <Alexander Udalov> * 0a00cbe - JVM IR: minor, refactor replaceThisByStaticReference (vor 6 Tagen) <Alexander Udalov> * ebb545a - (tag: build-1.4.30-dev-3106) Split ChangeLog file to files by major releases (vor 6 Tagen) <Margarita Bobova> * 71d3d8b - Add ChangeLog for 1.4.20 (vor 6 Tagen) <Margarita Bobova> * b1c355e - Directly search in IrClass for declarations to fill bodies with plugin (vor 6 Tagen) <Leonid Startsev> * 5efefab - (tag: build-1.4.30-dev-3102) [JS IR] webpackConfigAppliers as internal to not break Gradle lambda serialization in some cases (vor 6 Tagen) <Ilya Goncharov> * 42a9d64 - (tag: build-1.4.30-dev-3098) Track binary output class names (vor 6 Tagen) <Mikhael Bogdanov> * 6748560 - Proper support of aggregated processors (vor 6 Tagen) <Mikhael Bogdanov> * f382a55 - (tag: build-1.4.30-dev-3095) [JS IR] Add EXPECTED_REACHABLE_NODES for JS tests of external tail args (vor 6 Tagen) <Ilya Goncharov> * 176071b - Add support of nullable serializers to UseSerializers annotation (#3906) (vor 6 Tagen) <Sergey Shanshin> * 6c7247c - (tag: build-1.4.30-dev-3092) syncKotlinAndAndroidSourceSets: Don't register Kotlin source dirs in Android java source dirs (vor 6 Tagen) <sebastian.sellmair> * 2286498 - Share defaultSourceFolder logic between syncKotlinAndAndroidSourceSets.kt and KotlinSourceSetFactory.kt (vor 6 Tagen) <sebastian.sellmair> * 7c7eada - Add comment about unsupported associate compilations to functionalTest source files (vor 6 Tagen) <sebastian.sellmair> * 3f98e29 - Expand AndroidSourceSet#kotlinSourceSet to AndroidSourceSet#kotlinSourceSetOrNull (vor 6 Tagen) <sebastian.sellmair> * 3e5cbf3 - syncKotlinAndAndroidSourceSets.kt: Cover flavors with tests (vor 6 Tagen) <sebastian.sellmair> * cdfbbca - Also register `shaders` for kotlin source sets (vor 6 Tagen) <sebastian.sellmair> * 2c325c4 - Register Kotlin MPP source sets in AGP (vor 6 Tagen) <sellmair> * 3a166f3 - (tag: build-1.4.30-dev-3088) KT-43525 forbid @jvmoverloads on mangled funs and hidden constructors (vor 6 Tagen) <Dmitry Petrov> * ca78261 - (tag: build-1.4.30-dev-3080) Minor, fix "unknown -Xstring-concat mode" error message (vor 6 Tagen) <Alexander Udalov> * ed481ad - Fix performance regression in KotlinSuppressCache.isSuppressedByAnnotated (vor 6 Tagen) <Alexander Udalov> * efee3ea - (tag: build-1.4.30-dev-3076) [JS IR] - Remove file lowering declarations from lowering phases (vor 6 Tagen) <Ilya Goncharov> * 1b5ebd8 - [JS IR] Lazy initialisation is optional for tests (vor 6 Tagen) <Ilya Goncharov> * a2d41b8 - [JS IR] Add compiler argument about lazy initialisation (vor 6 Tagen) <Ilya Goncharov> * fcb3ee5 - [JS IR]Add check on pureness to not calculate fields to expression twice (vor 6 Tagen) <Ilya Goncharov> * aa0f9dc - [JS IR] Don't target exact wasm backend (vor 6 Tagen) <Ilya Goncharov> * c224394 - [JS IR] Return with createdOn hack (vor 6 Tagen) <Ilya Goncharov> * 8b4d42e - [JS IR] Add initialisation call for functions in method (vor 6 Tagen) <Ilya Goncharov> * 06b276f - [JS IR] Migrate on body lowering pass and declaration transformer (vor 6 Tagen) <Ilya Goncharov> * 99d0740 - [JS IR] Ignore JS_IR backend in top level side effect properties (vor 6 Tagen) <Ilya Goncharov> * d6bc309 - [JS IR] Eager initialisation for all pure properties (vor 6 Tagen) <Ilya Goncharov> * 3da9761 - [JS IR] Add test on lazy initialisation (vor 6 Tagen) <Ilya Goncharov> * f4c1e52 - [JS IR] Continuation parameter in main through accessor (vor 6 Tagen) <Ilya Goncharov> * 34ee146 - [JS IR] Internal visibility for init fun (vor 6 Tagen) <Ilya Goncharov> * 07b6ef6 - [JS IR] Init delegated properties as usual (vor 6 Tagen) <Ilya Goncharov> * 841118a - [JS IR] Add init properties call to top level functions (vor 6 Tagen) <Ilya Goncharov> * 5746a7c - [JS IR] Only consider top level properties (vor 6 Tagen) <Ilya Goncharov> * 0dc4f51 - [JS IR] Add init function call into first step of property accessor (vor 6 Tagen) <Ilya Goncharov> * 71bfed3 - [JS IR] From searcher get only properties, mutate in lowering (vor 6 Tagen) <Ilya Goncharov> * 42e1a32 - [JS IR] Add guard into init properties function (vor 6 Tagen) <Ilya Goncharov> * d752b74 - [JS IR] Add init function for properties (vor 6 Tagen) <Ilya Goncharov> * 003ea4b - (tag: build-1.4.30-dev-3070) [Gradle, MPP] Make metadata jar task cc-compatible with warnings (vor 6 Tagen) <Alexander Likhachev> * 3282e09 - (tag: build-1.4.30-dev-3058) [JS] Don't fail on recursive upper bounds while resolving JsExports (vor 7 Tagen) <Shagen Ogandzhanian> * f9a032d - (tag: build-1.4.30-dev-3053) FIR2IR: add AnnotationGenerator to Fir2IrComponents (vor 7 Tagen) <Jinseong Jeon> * eff4cec - FIR2IR: convert annotations on delegated members (vor 7 Tagen) <Jinseong Jeon> * d980074 - FIR: deserialize the `fun interface` flag (vor 7 Tagen) <pyos> * 20c7c48 - FIR: fix @JvmPackageName (vor 7 Tagen) <pyos> * 2d4e9af - (tag: build-1.4.30-dev-3046) [JS IR] Throw exception if test class or test method has explicit parameter (vor 7 Tagen) <Shagen Ogandzhanian> * c4a8d1c - (tag: build-1.4.30-dev-3044) FIR: use java functional interface as a source of sam function call (vor 7 Tagen) <Ilya Kirillov> * 7b1eef1 - FIR IDE: introduce KtFirCollectionLiteralReference (vor 7 Tagen) <Ilya Kirillov> * bac5ebc - FIR IDE: use custom thread local value for storing KtFirScopeProvider (vor 7 Tagen) <Ilya Kirillov> * b31def0 - FIR IDE: invalidate analysis session on project roots change (vor 7 Tagen) <Ilya Kirillov> * be95d06 - FIR IDE: add KotlinOutOfBlockPsiTreeChangePreprocessor (vor 7 Tagen) <Ilya Kirillov> * 7a86ca6 - FIR IDE: fix collecting diagnostics for anonymous object declaration (vor 7 Tagen) <Ilya Kirillov> * 7061608 - FIR IDE: introduce common function to mute tests (vor 7 Tagen) <Ilya Kirillov> * e4d2e38 - FIR IDE: fix reference resolving of qualified expression with nested classes (vor 7 Tagen) <Ilya Kirillov> * 164f4d1 - FIR IDE: do not collect diagnostics for generated declarations (vor 7 Tagen) <Ilya Kirillov> * 60cc302 - FIR IDE: update file structure testdata after structure elements classes rename (vor 7 Tagen) <Ilya Kirillov> * 75990f7 - FIR IDE: fix tesdata (vor 7 Tagen) <Ilya Kirillov> * 7320620 - FIR IDE: add local visibility to symbols (vor 7 Tagen) <Ilya Kirillov> * 5fdcc4b - FIR IDE: refactor KotlinFirModificationTrackerService (vor 7 Tagen) <Ilya Kirillov> * 112f677 - FIR IDE: fix compilation (vor 7 Tagen) <Ilya Kirillov> * 65b5e4b - FIR IDE: make some session components to be non-thread local (vor 7 Tagen) <Ilya Kirillov> * c3caa3a - FIR IDE: clean AbstractFirReferenceResolveTest (vor 7 Tagen) <Ilya Kirillov> * 3174eb4 - FIR IDE: do not get ktDeclaration for FirFile (vor 7 Tagen) <Ilya Kirillov> * ff7857a - FIR IDE: refactor, simplify structure element class names (vor 7 Tagen) <Ilya Kirillov> * 15277c0 - FIR IDE: introduce memory leak checking in symbols test (vor 7 Tagen) <Ilya Kirillov> * 11e94c1 - FIR IDE: fix building of local declaration symbols (vor 7 Tagen) <Ilya Kirillov> * e78e262 - FIR IDE: do not store cone session in every KtFirType (vor 7 Tagen) <Ilya Kirillov> * e54d16e - FIR IDE: fix fir declaration leak in symbols (vor 7 Tagen) <Ilya Kirillov> * b01ee16 - FIR IDE: wrap KotlinDeserializedJvmSymbolsProvider into thread safe cache (vor 7 Tagen) <Ilya Kirillov> * 911662b - FIR IDE: introduce out of block modification tracker tests (vor 7 Tagen) <Ilya Kirillov> * da7b12f - FIR IDE: introduce ProjectWideOutOfBlockKotlinModificationTrackerTest (vor 7 Tagen) <Ilya Kirillov> * 880e76b - FIR IDE: introduce FIR IDE specific out of block modification tracker (vor 7 Tagen) <Ilya Kirillov> * 6c1faec - FIR IDE: introduce file structure tests (vor 7 Tagen) <Ilya Kirillov> * 7c912cd - FIR IDE: introduce FileElementFactory (vor 7 Tagen) <Ilya Kirillov> * 315629c - FIR IDE: refactor lock provider (vor 7 Tagen) <Ilya Kirillov> * 559b07d - FIR IDE: fix memory leak in scope provider (vor 7 Tagen) <Ilya Kirillov> * 64895fe - (tag: build-1.4.30-dev-3035) [JS IR] Test with js specific moved to `js.translator` (vor 7 Tagen) <Ilya Goncharov> * fe3030c - [JS IR] Drop last null arguments in calls of external functions (vor 7 Tagen) <Ilya Goncharov> * 5c731c6 - [JS IR] Add test in external js fun with default args (vor 7 Tagen) <Ilya Goncharov> * 8eb2ae1 - (tag: build-1.4.30-dev-3030) FIR checker: refactor EventOccurrencesRange accumulation (vor 7 Tagen) <Jinseong Jeon> * b9d3578 - FIR checker: refactor ControlFlowInfos whose key is EdgeLabel (vor 7 Tagen) <Jinseong Jeon> * b6a4c27 - FIR checker: refactor ControlFlowInfos whose value is EventOccurrencesRange (vor 7 Tagen) <Jinseong Jeon> * cf8f5b0 - FIR checker: make calls effect analyzer path-sensitive (vor 7 Tagen) <Jinseong Jeon> * 2662679 - (tag: build-1.4.30-dev-3022) KT-43399 properly erase extension receiver type in property$annotations (vor 7 Tagen) <Dmitry Petrov> * 551d0c1 - JVM_IR KT-43440 private-to-this default interface funs are private (vor 7 Tagen) <Dmitry Petrov> * bf7fdcd - KT-42909 fix missing loop variable in 'withIndex' ranges (vor 7 Tagen) <Dmitry Petrov> * a9c9406 - [Gradle, K/N] Set LIBCLANG_DISABLE_CRASH_RECOVERY=1 for cinterop (vor 7 Tagen) <Ilya Matveev> * 37197a9 - Update ReadMe.md (vor 7 Tagen) <Alexander Anisimov> * 18612c1 - (tag: build-1.4.30-dev-3019) [JVM+IR] Rebase LVT test of destructuing in lambda params (vor 7 Tagen) <Kristoffer Andersen> * ccc272c - (tag: build-1.4.30-dev-3015) KT-43489: KGP - Avoid storing build history mapping in a property (vor 7 Tagen) <Ivan Gavrilovic> * 2c28e65 - (tag: build-1.4.30-dev-3012) Add JetBrains to the first part of text (vor 7 Tagen) <Alexander Anisimov>
erokhins
pushed a commit
that referenced
this pull request
Feb 26, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.