fix: change Maven version from 3.5.1 to 3.8.6 as 3.5.1 doesn't exist:) #4140
+2
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koshachy
approved these changes
Apr 19, 2024
There was a problem hiding this comment.
Hey @PetrakovichVictoria
Thanks for your contribution!
I'll wait @CherepanovAleksei for an approval.
|
ftr, we need to revise the versions - the proposed version refers to the mvn version, but not to the version maven compiler plugin (https://mvnrepository.com/artifact/org.apache.maven.plugins/maven-compiler-plugin) |
|
We'll decide whether we should update this version or not. Anyway, it's not critical at all, so let it be a draft for a while. JFYI: When configuring Kotlin in a Java project, the line with the version number is not added at all:) We're investigating if it's a bug. UPD: I remember about it:) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The version 3.5.1 doesn't exist, see here: https://maven.apache.org/docs/history.html#maven-3-8-x
3.8.6 is chosen by advice from @CherepanovAleksei as we use this version.