GD0001: partial modifier static analysis for Godot 4

[Sythelux]

Godot 4 now requires anything inheriting from Godot.Object to be partial. The Plugin doesn't recognise this, yet

example code:

public class Main : Node3D
{
	public override void _Ready()
	{
		GD.Print("_Ready");
	}
}

This looks fine in Rider, but when building in Godot it yields:

[...]\Main.cs(4,1): Error GD0001 : Missing partial modifier on declaration of type 'Main' which is a subclass of 'Godot.Object'

It would be good to have a static analysis of Rider to show that error in the editor before building.

[van800]

I think it might be worth implementing such a roslyn analyser in the Godot source itself, somewhere near the source generator, which produces that error.
That way all IDE-s (including Rider) would automatically display the error.

[Sythelux]

I think it might be worth implementing such a roslyn analyser in the Godot source itself, somewhere near the source generator, which produces that error. That way all IDE-s (including Rider) would automatically display the error.

can you point me to a typical roslyn implementation in another repo or the Roslyn doc for that? This sounds like an Issue I would be able to solve in the core.

[van800]

Try looking in https://github.com/microsoft/Microsoft.Unity.Analyzers

[van800]

Should be implemented in the engine similar to godotengine/godot#79007

[van800]

I have started making a pull request godotengine/godot#87253, currently in discussion.

[van800]

Merged today.

[Sythelux]

I followed the discussions about it in the godot project and the refactoring it lead to. Thank you a lot of taking care if it!