LocalLayoutDirection isn't propagated into DialogWindow

[mahozad]

Describe the bug
Creating this bug as was requested here: #3142 (comment)

LocalLayoutDirection.current returns LTR even when set to RTL outside a Dialog.

Affected platforms
Select one of the platforms below:

• Desktop

Versions

• Kotlin version*: 1.8.20
• Compose Multiplatform version*: 1.4.1
• OS version(s)* (required for Desktop and iOS issues): Windows 11
• OS architecture (x86 or arm64): x64
• JDK (for desktop issues): 17

Expected behavior
The provided layout direction should be seen inside the dialog composable.

[mahozad]

The new common Dialog component in version 1.5.0-beta01 does not have this problem.

[m-sasha]

Indeed. This is because Dialog has been reimplemented on top of Popup, which already had this fixed.

[m-sasha]

Although there's now the same issue with DialogWindow, most likely.

[mahozad]

The problem still exists with DialogWindow in version 1.5.0-beta01:

fun main() {
    application {
        var direction by remember { mutableStateOf(LayoutDirection.Rtl) }
        CompositionLocalProvider(LocalLayoutDirection provides direction) {
            DialogWindow(onCloseRequest = ::exitApplication) {
                // /* Workaround: */ CompositionLocalProvider(LocalLayoutDirection provides direction) {
                Column(modifier = Modifier.fillMaxWidth()) {
                    Text("$direction")
                    Button(onClick = { direction = if (direction == LayoutDirection.Rtl) LayoutDirection.Ltr else LayoutDirection.Rtl }) {
                        Text("Change direction")
                    }
                }
                // }
            }
        }
    }
}

[m-sasha]

Fixed by JetBrains/compose-multiplatform-core#777

[okushnikov]

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.