Deprecate 3 overloads of StyleScope.borderWidth with wrong parameter names #2297
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The reason is wrong parameter names. The behaviour is still correct. The idea is to fix the parameter names in 2.0 (which is more appropriate for breaking changes)
dima-avdeev-jb
approved these changes
Sep 7, 2022
igordmn
reviewed
Sep 7, 2022
web/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/properties/border.kt
Outdated
Show resolved
Hide resolved
web/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/properties/border.kt
Outdated
Show resolved
Hide resolved
web/core/src/jsMain/kotlin/org/jetbrains/compose/web/css/properties/border.kt
Outdated
Show resolved
Hide resolved
eymar
changed the title
igordmn
approved these changes
Sep 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Final solution:
3 borderWidth methods have wrong parameters names.
We can't just change the parameters names, because it would be a breaking change.
Fix consists of 2 things:
unused: Unit? = nullparameter. We mark those 3 old methods as deprecated.borderWidthmethods with correct parameters names.The deprecated methods will be removed not earlier than 1.4
This PR is an alternative for #1982