Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement "actual fun ActualDialog" and "actual fun ActualPopup" #19

Closed
igordmn opened this issue Oct 20, 2020 · 2 comments
Closed

Implement "actual fun ActualDialog" and "actual fun ActualPopup" #19

igordmn opened this issue Oct 20, 2020 · 2 comments
Assignees
@Rsedaikin
Labels
enhancement New feature or request
Milestone
M2

Comments

@igordmn
Copy link
Collaborator

igordmn commented Oct 20, 2020

We can move already implemented Dialog/Popup from desktop to ui module

from:
support\compose\desktop\desktop\src\jvmMain\kotlin\androidx\compose\ui\window\AppDialog.kt
to:
support\compose\ui\ui\src\desktopMain\kotlin\androidx\compose\ui\window\DesktopDialog.kt

from:
support\compose\desktop\desktop\src\jvmMain\kotlin\androidx\compose\ui\window\Popup.kt
to:
support\compose\ui\ui\src\desktopMain\kotlin\androidx\compose\ui\window\DesktopPopup.kt

(DesktopPopup is in ui module, so we can't use Box, we have to use Layout (as in support\compose\ui\ui\src\androidMain\kotlin\androidx\compose\ui\window\AndroidPopup.kt)
@igordmn igordmn added the enhancement New feature or request label Oct 22, 2020
@igordmn igordmn mentioned this issue Nov 10, 2020
Closed
@olonho olonho added this to the M2 milestone Nov 12, 2020
@VdBarros VdBarros mentioned this issue Apr 19, 2024
Closed
@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@okushnikov
Copy link
Collaborator

Please check the following ticket on YouTrack for follow-ups to this issue. GitHub issues will be closed in the coming weeks.

@JetBrains JetBrains locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@Rsedaikin Rsedaikin

Labels
enhancement New feature or request
Projects
None yet
Milestone
M2
Development

No branches or pull requests
4 participants
@olonho @igordmn @Rsedaikin @okushnikov