Fix AlertDialog dismiss on click to Dialog content. #359
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JetBrains/compose-multiplatform#2580 Also, add temporary PopupDialog. In the future it should be changed to LayerDialog.(JetBrains/compose-multiplatform#933)
igordmn
reviewed
Jan 4, 2023
.../foundation/src/desktopMain/kotlin/androidx/compose/foundation/dialog/PopupDialog.desktop.kt
Outdated
Show resolved
Hide resolved
.../foundation/src/desktopMain/kotlin/androidx/compose/foundation/dialog/PopupDialog.desktop.kt
Outdated
Show resolved
Hide resolved
… dima-avdeev/Issue-2581-fix-alert-dialog-dismiss # Conflicts: # compose/foundation/foundation/src/desktopMain/kotlin/androidx/compose/foundation/dialog/PopupDialog.desktop.kt
igordmn
approved these changes
Jan 5, 2023
Base automatically changed from
dima-avdeev/Issue-2580-desktop-alert-dialog-scrim
to
jb-main
January 5, 2023 14:58
dima-avdeev-jb
deleted the
dima-avdeev/Issue-2581-fix-alert-dialog-dismiss
branch
eymar
pushed a commit
that referenced
this pull request
Jan 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue JetBrains/compose-multiplatform#2581
Previously, AllertDialog was dismissed by clicking on content.
dismiss-alert-dialog.mp4
New behaviour will be the same as in Android