Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bad interaction with Swift's string interpolation #65

Closed
tonyarnold opened this issue Jan 20, 2020 · 5 comments
Closed

Bad interaction with Swift's string interpolation #65

tonyarnold opened this issue Jan 20, 2020 · 5 comments

Comments

@tonyarnold
Copy link

I've come across a situation with a ligature that I'd prefer not to display. I understand that this might not be possible, but here's a report all the same:

Given the following Swift string:

let somePath = "/administration/organizations/\(anotherString)"

Using JetBrains Mono produces the following result:

image

Obviously the /\ is unintentional, and probably quite situation/language specific.

@CreamyCookie
Copy link

Would #11 (Spacing only ligatures variant) help for that?

@pakLebah
Copy link

pakLebah commented Jan 22, 2020

It's quite annoying actually which forces me to back to Fira Code when I write Swift code. Please fix this ASAP. Thank you.

@philippnurullin
Copy link
Member

philippnurullin commented Jan 27, 2020

Consulted with @tonsky on matter of \/ /\. Looks like there is no way to make them work good. Too many exclusions, so in 1.0.3 we will remove thees ligatures.

@tonyarnold
Copy link
Author

Ah, that's a shame.

Look, I have to say that I understand that the use of JetBrains Mono with Swift probably isn't the primary use case so I'd be understanding if you left these ligatures in if they don't affect languages such as your own (Kotlin).

@pakLebah
Copy link

A coding font should have no bias toward any specific programming languages.

philippnurullin added a commit that referenced this issue Feb 7, 2020
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
philippnurullin added a commit that referenced this issue Feb 7, 2020
— Added support of Box Drawings 159 symbols #84 #55
— Added ligature `<--` #95
— Removed the `\/` & `/\` ligatures #65 #76 #78 #83
— Corrected behaviour of ligatures in a glob pattern #88
— Changed the `$` & dependent glyphs #110
— Added no-break space #94
— Corrected unexpected `>=` ligature usage in `>=<` sequence 
— Refactored `w`, `W`, `m`, `M`
— Slightly tuned ascenders & descenders
— Added support of Mongolian language #81
— Better placement of the dot in 0 #104
— Reorganised family names #122
— Updated download link in README.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants