diff --git a/CHANGELOG.md b/CHANGELOG.md index ae4d1128e2..a1c9525dd4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts-monorepo + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) diff --git a/lerna.json b/lerna.json index a0c22748b9..0a787790df 100644 --- a/lerna.json +++ b/lerna.json @@ -12,5 +12,5 @@ ] } }, - "version": "0.37.0" + "version": "0.37.1" } diff --git a/packages/angular/CHANGELOG.md b/packages/angular/CHANGELOG.md index 778bc7fa0c..30b1317453 100644 --- a/packages/angular/CHANGELOG.md +++ b/packages/angular/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts-angular + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) **Note:** Version bump only for package @carbon/charts-angular diff --git a/packages/angular/package.json b/packages/angular/package.json index 848172d914..81c5adb476 100644 --- a/packages/angular/package.json +++ b/packages/angular/package.json @@ -1,6 +1,6 @@ { "name": "@carbon/charts-angular", - "version": "0.37.0", + "version": "0.37.1", "description": "Carbon charting components for Angular", "main": "index.js", "scripts": { @@ -40,7 +40,7 @@ "scss" ], "dependencies": { - "@carbon/charts": "^0.37.0" + "@carbon/charts": "^0.37.1" }, "peerDependencies": { "@angular/common": "^6.0.0 || ^7.0.0 || ^8.0.0 || ^9.0.0", diff --git a/packages/core/CHANGELOG.md b/packages/core/CHANGELOG.md index e2518f6404..97a06d3d84 100644 --- a/packages/core/CHANGELOG.md +++ b/packages/core/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) diff --git a/packages/core/package.json b/packages/core/package.json index 4200d2c27b..9a95552b4f 100644 --- a/packages/core/package.json +++ b/packages/core/package.json @@ -1,6 +1,6 @@ { "name": "@carbon/charts", - "version": "0.37.0", + "version": "0.37.1", "description": "Carbon charting components", "main": "./bundle.js", "module": "./index.js", diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md index b1f99ed3a3..1ec70fd9f1 100644 --- a/packages/react/CHANGELOG.md +++ b/packages/react/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts-react + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) **Note:** Version bump only for package @carbon/charts-react diff --git a/packages/react/package.json b/packages/react/package.json index 979f6ac376..bdb418a386 100644 --- a/packages/react/package.json +++ b/packages/react/package.json @@ -1,6 +1,6 @@ { "name": "@carbon/charts-react", - "version": "0.37.0", + "version": "0.37.1", "description": "Carbon charting components for React", "main": "./bundle.js", "module": "./index.js", @@ -46,7 +46,7 @@ }, "homepage": "https://github.com/carbon-design-system/carbon-charts#readme", "dependencies": { - "@carbon/charts": "^0.37.0" + "@carbon/charts": "^0.37.1" }, "peerDependencies": { "react": "^16.6.3", diff --git a/packages/svelte/CHANGELOG.md b/packages/svelte/CHANGELOG.md index d7be3be7c5..7f616425c8 100644 --- a/packages/svelte/CHANGELOG.md +++ b/packages/svelte/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts-svelte + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) **Note:** Version bump only for package @carbon/charts-svelte diff --git a/packages/svelte/package.json b/packages/svelte/package.json index 2fd46e8491..ee00ccd8a8 100644 --- a/packages/svelte/package.json +++ b/packages/svelte/package.json @@ -1,6 +1,6 @@ { "name": "@carbon/charts-svelte", - "version": "0.37.0", + "version": "0.37.1", "description": "Carbon charting components for Svelte", "main": "./bundle.js", "module": "./index.js", @@ -47,7 +47,7 @@ }, "homepage": "https://github.com/carbon-design-system/carbon-charts#readme", "dependencies": { - "@carbon/charts": "^0.37.0" + "@carbon/charts": "^0.37.1" }, "peerDependencies": { "svelte": "^3.20.x" diff --git a/packages/svelte/src/BaseChart.svelte b/packages/svelte/src/BaseChart.svelte index 4bcf201d39..bdf1174c48 100644 --- a/packages/svelte/src/BaseChart.svelte +++ b/packages/svelte/src/BaseChart.svelte @@ -8,17 +8,17 @@ const dispatch = createEventDispatcher(); const id = "chart-" + Math.random().toString(36); - let ref = undefined; - let chart = undefined; + let ref = null; + let chart = null; onMount(() => { /** * CodeSandbox does not resolve Svelte components from the `svelte` package.json entry. * This causes `bind:ref` to be `undefined`; the chart can't mount to the element. - * + * * We fallback to manually querying the DOM for the chart holder element because * CodeSandbox does not use uncompiled Svelte source code. - * + * * See https://github.com/sveltejs/svelte/issues/2937 */ const element = ref || document.getElementById(id); @@ -30,7 +30,8 @@ return () => { if (chart) { - chart.destroy(); + chart.components.forEach((component) => component.destroy()); + chart = null; dispatch("destroy"); } }; diff --git a/packages/vue/CHANGELOG.md b/packages/vue/CHANGELOG.md index 423025b3f3..99ade74cad 100644 --- a/packages/vue/CHANGELOG.md +++ b/packages/vue/CHANGELOG.md @@ -3,6 +3,14 @@ All notable changes to this project will be documented in this file. See [Conventional Commits](https://conventionalcommits.org) for commit guidelines. +## [0.37.1](https://github.com/carbon-design-system/carbon-charts/compare/v0.37.0...v0.37.1) (2020-09-14) + +**Note:** Version bump only for package @carbon/charts-vue + + + + + # [0.37.0](https://github.com/carbon-design-system/carbon-charts/compare/v0.36.4...v0.37.0) (2020-09-11) **Note:** Version bump only for package @carbon/charts-vue diff --git a/packages/vue/package.json b/packages/vue/package.json index 7db95ced5d..76eecdaeff 100644 --- a/packages/vue/package.json +++ b/packages/vue/package.json @@ -1,6 +1,6 @@ { "name": "@carbon/charts-vue", - "version": "0.37.0", + "version": "0.37.1", "description": "Carbon charting components for Vue", "main": "charts-vue.umd.min.js", "scripts": { @@ -14,7 +14,7 @@ "clean": "rm -rf dist demo/bundle" }, "dependencies": { - "@carbon/charts": "^0.37.0", + "@carbon/charts": "^0.37.1", "vue": "2.5.21" }, "devDependencies": {